Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/49#discussion_r41101294
--- Diff:
excel/src/main/java/org/apache/metamodel/excel/ExcelUpdateCallback.java ---
@@ -78,7 +87,24 @@ public ExcelDataContext getDataContext() {
protected void close() {
if (_workbook != null) {
- ExcelUtils.writeWorkbook(_dataContext, _workbook);
+
+ final Resource resource;
+ if(_dataContext.getResource() instanceof FileResource){
--- End diff --
I think it was an attempt to avoid file locking issues I saw with
File-based Excel writing on close. In the end of my attempts there was quite a
bit of throwing stuff at the wall to see what stuck (I couldn't test locally,
as only Travis would fail).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
