[GitHub] [metamodel] GerardDellemann commented on a change in pull request #234: MM-82 Detect Column Types

[GitBox]

GerardDellemann commented on a change in pull request #234: MM-82 Detect Column 
Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r355345785
 
 

 ##########
 File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
 ##########
 @@ -232,18 +279,36 @@ public static String getCellValue(Workbook wb, Cell 
cell) {
             throw new IllegalStateException("Unknown cell type: " + 
cell.getCellType());
         }
 
-        logger.debug("cell {} resolved to value: {}", cellCoordinate, result);
+        logger.debug("cell {} resolved to value: {}", 
getCellCoordinates(cell), result);
 
         return result;
     }
 
+    public static Object getCellValueChecked(final Workbook workbook, final 
Cell cell,
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services