GerardDellemann commented on a change in pull request #234: MM-82 Detect Column
Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r355459111
##########
File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
##########
@@ -264,12 +338,13 @@ private static String getFormulaCellValue(Workbook wb,
Cell cell) {
return getCellValue(wb, evaluatedCell);
} catch (RuntimeException e) {
- logger.warn("Exception occurred while evaluating formula at
position ({},{}): {}",
- new Object[] { cell.getRowIndex(), cell.getColumnIndex(),
e.getMessage() });
+ logger
+ .warn("Exception occurred while evaluating formula at
position ({},{}): {}", cell.getRowIndex(),
+ cell.getColumnIndex(), e.getMessage());
// Some exceptions we simply log - result will be then be the
// actual formula
if (e instanceof FormulaParseException) {
- logger.error("Parse exception occurred while evaluating cell
formula: " + cell, e);
+ logger.warn("Parse exception occurred while evaluating cell
formula: " + cell, e);
Review comment:
ok, then I also apply that change to getFormulaCellValueAsObject(...)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
