GerardDellemann commented on a change in pull request #234: MM-82 Detect Column
Types
URL: https://github.com/apache/metamodel/pull/234#discussion_r355467479
##########
File path: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java
##########
@@ -281,6 +356,51 @@ private static String getFormulaCellValue(Workbook wb,
Cell cell) {
return cell.getCellFormula();
}
+ private static Object getFormulaCellValueAsObject(final Workbook workbook,
final Cell cell) {
+ // first try with a cached/precalculated value
+ try {
+ return getDoubleAsNumber(cell.getNumericCellValue());
+ } catch (final Exception e) {
+ if (logger.isInfoEnabled()) {
+ logger.info("Failed to fetch cached/precalculated formula
value of cell: " + cell, e);
+ }
+ }
+
+ // evaluate cell first, if possible
+ try {
Review comment:
ok, I've put it into a method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
