LiveSatomi commented on a change in pull request #240: METAMODEL-1225 Add
ColumnTypingStrategies and use them in CSV module.
URL: https://github.com/apache/metamodel/pull/240#discussion_r402315872
##########
File path: csv/src/test/java/org/apache/metamodel/csv/CsvDataContextTest.java
##########
@@ -492,7 +490,7 @@ public void testMaterializeTable() throws Exception {
public void testAlternativeDelimitors() throws Exception {
File file = new
File("src/test/resources/csv_semicolon_singlequote.csv");
CsvDataContext dc = new CsvDataContext(file, semicolonConfiguration);
- Table table = dc.getSchemas().get(0).getTables().get(0);
Review comment:
This tripped me up for a while, it turns out _getSchemas().get(0)_ returns
the schema for information_schema while _getDefaultSchema()_ returns the schema
for specified resource. Now that the typing on the schema matters for reads
dataSet.next() includes a cast which was failing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
