arjansh commented on a change in pull request #240: METAMODEL-1225 Add ColumnTypingStrategies and use them in CSV module. URL: https://github.com/apache/metamodel/pull/240#discussion_r408781608
########## File path: core/src/main/java/org/apache/metamodel/schema/typing/ColumnTypingContext.java ########## @@ -0,0 +1,44 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.metamodel.schema.typing; + +import org.apache.metamodel.schema.ColumnType; +import org.apache.metamodel.schema.Table; + +/** + * Defines the context for configuring the type for a single column in a + * {@link ColumnTypingStrategy} session. + */ +public interface ColumnTypingContext { Review comment: Why have both a `ColumnTypingContext` interface and a `ColumnTypingContextImpl`. In this case you have exactly one implementation of an interface, for which I don't expect you want to create different implementations in the future, so I would personally drop the interface and rename the implementation to `ColumnTypingContext`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
