arjansh commented on a change in pull request #240: METAMODEL-1225 Add
ColumnTypingStrategies and use them in CSV module.
URL: https://github.com/apache/metamodel/pull/240#discussion_r408841742
##########
File path: csv/src/test/java/org/apache/metamodel/csv/CsvDataContextTest.java
##########
@@ -833,8 +831,14 @@ public void testCustomColumnNames() throws Exception {
final String thirdColumnName = "third";
final String fourthColumnName = "fourth";
+ final ColumnType firstColumnType = ColumnType.STRING;
Review comment:
I don't think it adds real value to put these constants into the
xxxColumnType variables, especially since they're only used once. It doesn't
make the code more understandable or more elegant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
