GitHub user iraghumitra opened a pull request:
https://github.com/apache/metron/pull/857
METRON-1340: Improve e2e tests for metron alerts
## Contributor Comments
This PR aims to improve the existing e2e tests of metro-alerts in the areas
mentioned below. The PR doesn't add/remove any functionality to the existing
alerts ui. However, there are few changes in HTML templates where I a needed a
new selector for tests.
- Delete the contents of table 'metron_update' in HBase
- I have added a nodes script that deletes the 'metron_update' table
before each run of e2e tests
- Ensure that the tests run consistently on latest version of node
- I have tested and added a check to node version 8.9. If the version is
less than 8.9 there is a warning and tests run continues
- Improving description of test specs
- Added meaningful descriptions wherever applicable. Let me know if we
need any more descriptions
- Run the tests on a headless browser to improve reliability
- Added the headless option to protractor.conf.js
The tests are written using:
OS: macOS High Sierra 10.13.1
nodejs: v8.9.1.
Chrome: 62.0.3202.94
The tests should run reasonably well on other platforms since I personally
didn't test on them I would request you to report any tests failure with
information about your OS, nodejs and browser version.
I bumped up the version of the protractor to 5.2.0, so please run npm
install before testing the PR. Please let me know if you need any more details
about the PR.
### Testing
If all the e2e tests run fine the PR is good.
### Documentation
No new documentation is needed specifically for this PR. The steps to run
the e2e tests remains the way they are before. I added a couple of caveats in
Readme about deleting 'metron_update' table and headless chrome. Please let me
know if we can improve our docs for e2e tests I would be glad to add it.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [x] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [x] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iraghumitra/incubator-metron METRON-1340
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #857
----
commit d43eb1cdc0a502ef7e00e73f7b15f5d16d7e1cae
Author: iraghumitra <[email protected]>
Date: 2017-12-03T18:09:58Z
Initial commit for e2e test improvements
----
---
