Github user iraghumitra commented on the issue:

    https://github.com/apache/metron/pull/857
  
    @merrimanr 
    - I removed the node version check in the ui code
    - The browser.sleep is used in following areas
           - When we are using methods like waitForText, few times I see the 
test fails saying that that it got the text we were waiting to change which 
doesn't make sense. So, in this case, i am just yielding the main thread with a 
sleep of 500 milliseconds.
           - Create/Add meta-alert, these calls takes few seconds at times.
           - When we use animation to slide in the details pane, we don't have 
a class that gets added/removed for this so it makes it difficult for us to 
know when the pane is loaded. We can add/remove a class for animation by moving 
the slider to a component or directive. This might be out of scope for current 
PR.
    - Refactored tests for Facets
    - Looks like the meta alert creation failed can you attach the stack trace 
it might give me additional info to debug. 


---

Reply via email to