Github user nickwallen commented on a diff in the pull request:

    
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r170471879
  
    --- Diff: scripts/Apache/Kafka/logs-to-kafka.bro ---
    @@ -22,7 +22,7 @@ event bro_init() &priority=-5
     {
        for (stream_id in Log::active_streams)
        {
    -           if (stream_id in Kafka::logs_to_send)
    +           if ((|logs_to_send| == 0) || stream_id in Kafka::logs_to_send)
    --- End diff --
    
    As @JonZeolla mentioned, defaulting to "all logs on" is something that 
we've talked through before.  We should handle this as a separate PR with its 
own discussion.  I would take this out of the current PR.


---

Reply via email to