Github user nickwallen commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r170469201
--- Diff: src/KafkaWriter.cc ---
@@ -54,20 +66,51 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend):
WriterBackend(frontend), for
}
KafkaWriter::~KafkaWriter()
-{}
+{
+ // Cleanup Kafka resources
+ while (producer->outq_len() > 0) {
--- End diff --
Waiting for the queue to clear is already performed in
[DoFinish](https://github.com/rocknsm/metron-bro-plugin-kafka/blob/3bf94c7cfd06995280476c7c62f63616ce82ac3f/src/KafkaWriter.cc#L187-L191).
Why do this again?
---
