[GitHub] metron-bro-plugin-kafka pull request #6: Configurable JSON timestamps and de...

[dcode]

Github user dcode commented on a diff in the pull request:

    
https://github.com/apache/metron-bro-plugin-kafka/pull/6#discussion_r172036590
  
    --- Diff: src/KafkaWriter.cc ---
    @@ -54,20 +66,51 @@ KafkaWriter::KafkaWriter(WriterFrontend* frontend): 
WriterBackend(frontend), for
     }
     
     KafkaWriter::~KafkaWriter()
    -{}
    +{
    +    // Cleanup Kafka resources
    +    while (producer->outq_len() > 0) {
    --- End diff --
    
    My oversight of comparing my old plugin code to this. Good catch.


---