[
https://issues.apache.org/jira/browse/DIRMINA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514829
]
Trustin Lee commented on DIRMINA-376:
-------------------------------------
A few comments:
1) Tabs and spaces are mixed. Spaces are always preferred.
2) logSettings could be final.
3) logSettings could be something like CopyOnWriteMap for maximum concurrency.
CopyOnWriteMap doesn't exist in JDK, so we could provide it in
org.apache.mina.util. Or it might be included in commons-collections?
4) Let's add setLogLevel(IoEventType, LogLevel) and change all set<event
name>LogLevel methods to call setLogLevel().
Except them, I love the implementation! Great work!
> Fine-grained logging control in LoggingFilter
> ---------------------------------------------
>
> Key: DIRMINA-376
> URL: https://issues.apache.org/jira/browse/DIRMINA-376
> Project: MINA
> Issue Type: New Feature
> Components: Filter
> Reporter: Trustin Lee
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> LoggingFilter of MINA 1.0 has limited usability because there's no way to
> disable certain log messages. For example, you can't:
> * disable logging for certain event type (e.g. exceptionCaught, which is
> often logged again in IoHandler.exceptionCaught()).
> * log only certain type of received messages
> Category filtering feature provided by logging frameworks will solve this
> problem somewhat, but it's very coarse-grained and won't work as expected
> because LoggingFilter gets the logger instance using the IoHandler
> implementation class and therefore affect logging messages in an IoHandler
> implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
