[ 
https://issues.apache.org/jira/browse/DIRMINA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12515142
 ] 

Trustin Lee commented on DIRMINA-376:
-------------------------------------

The implementation looks somewhat weird.  It's modifying the map before 
creating a new copy.  And if we are going to use a ConcurrentHashMap, we won't 
even need to make a copy of it.  I found an existing implementation that might 
help you in Commons Collections:

http://jakarta.apache.org/commons/collections/api-release/org/apache/commons/collections/FastHashMap.html

Source code:

http://www.krugle.com/kse/codespaces/EPwm08

> Fine-grained logging control in LoggingFilter
> ---------------------------------------------
>
>                 Key: DIRMINA-376
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-376
>             Project: MINA
>          Issue Type: New Feature
>          Components: Filter
>            Reporter: Trustin Lee
>            Assignee: Mark Webb
>            Priority: Minor
>             Fix For: 2.0.0-M1
>
>
> LoggingFilter of MINA 1.0 has limited usability because there's no way to 
> disable certain log messages.  For example, you can't:
> * disable logging for certain event type (e.g. exceptionCaught, which is 
> often logged again in IoHandler.exceptionCaught()).
> * log only certain type of received messages
> Category filtering feature provided by logging frameworks will solve this 
> problem somewhat, but it's very coarse-grained and won't work as expected 
> because LoggingFilter gets the logger instance using the IoHandler 
> implementation class and therefore affect logging messages in an IoHandler 
> implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to