[
https://issues.apache.org/jira/browse/DIRMINA-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12514831
]
Trustin Lee commented on DIRMINA-376:
-------------------------------------
Mark wrote: (All comments should be written here, instead of replying to the
JIRA notification message directly.)
Thanks for the feedback! The best part about this class (to me) is that it
stores nothing in the session, which after seeing all of the OOM discussion
on the mailing list means alot.
Comments to your comments ;)
1. fixed.
2. fixed.
3. I need to find this class somewhere. Seems to me that this was discussed
in the Java Concurrency In Practice. I left my copy at work and will look
at it in the morning.
4. fixed.
Trustin, do you recommend I check this in to the trunk and overwrite the
current version of LoggingFilter once I fix what you commented on?
> Fine-grained logging control in LoggingFilter
> ---------------------------------------------
>
> Key: DIRMINA-376
> URL: https://issues.apache.org/jira/browse/DIRMINA-376
> Project: MINA
> Issue Type: New Feature
> Components: Filter
> Reporter: Trustin Lee
> Priority: Minor
> Fix For: 2.0.0-M1
>
>
> LoggingFilter of MINA 1.0 has limited usability because there's no way to
> disable certain log messages. For example, you can't:
> * disable logging for certain event type (e.g. exceptionCaught, which is
> often logged again in IoHandler.exceptionCaught()).
> * log only certain type of received messages
> Category filtering feature provided by logging frameworks will solve this
> problem somewhat, but it's very coarse-grained and won't work as expected
> because LoggingFilter gets the logger instance using the IoHandler
> implementation class and therefore affect logging messages in an IoHandler
> implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
