Thanks Julien this is cool. Trustin why isn't any of this code documented? Would be nice if users can see what this is about ... might make people use it more.
Alex On Feb 5, 2008 3:07 AM, Julien Vermillard <[EMAIL PROTECTED]> wrote: > On Mon, 04 Feb 2008 22:02:19 -0700 > Jeff Genender <[EMAIL PROTECTED]> wrote: > > > > > > > Mike Heath wrote: > > > To clarify, my understanding of pipelining is that it is sending > > > multiple requests and then waiting for the corresponding responses. > > > This is more than HTTP keep alive which would also allow using a > > > single connection for multiple requests but doesn't necessarily > > > involve the batching of pipelining. > > > > I understand it slightly different..that you can send multiple > > requests through the same socket. The difference between what you > > said and what I said is I think pipelining does not have stacked > > waiting. > > > > > > > >> But if you are saying its possible, then great! > > > > > > What I'm saying is that in the AHC code at > > > > http://svn.apache.org/repos/asf/geronimo/sandbox/async-http-client-mina2, > > > the HttpIoHandler.TimeoutTask is unaware of which request has been > > > sent. It only knows which IoSession is being used (that's the only > > > field in the TimeoutTask). So essentially the timeout logic as it > > > is implemented in AHC is no different than using the MINA idle > > > logic. > > > > > > Does the AHC client currently support pipelining? If I issue two > > > pipelined requests, and the first one times out causing the session > > > to close. How does the future of the second request get notified > > > of the timeout? I only see code for working with CURRENT_REQUEST > > > (from the IoSession attributes). I don't see any code for dealing > > > with pending requests. > > > > > > > You are right....no AHC does not support pipelining but we were coding > > it to go in that direction so we could. We knew that it would be a > > lot more complex to implement, but wanted to sow the seeds of the > > code to handle it when we did. > > > > OTOH, I must admit I implemented the ScheduledExecutor based on the > > FAQ and a few IRC discussions ;-) but if sessionIdle will work, then > > that would be the way to go. > > > > > -Mike > > > > > > BTW - Thanks for the discussion, Jeff. It's really helped me to go > > > back and look deeper in the AHC code. > > > > Thank you...and thanks for taking an interest...this is great ;-) > > > > > > > > -Mike > > Hi, > > Just by the way, if you want to monitor a request/response behaviour you > got the reqres filter : > > http://svn.apache.org/viewvc/mina/trunk/core/src/main/java/org/apache/mina/filter/reqres/ > > Julien >
