Cool, so I'll add it and ask for a review when its in SVN.
Talking about that class, the following method seems a bit odd:
public void block(InetAddress address, String error_string) {
if (address == null) {
throw new NullPointerException(error_string);
}
blacklist.add(address);
}
Should that method really be public? It is used by some other methods
in the filter, but I fail to see any use for it in the public API.
/niklas
On Wed, Mar 12, 2008 at 5:53 PM, Alex Karasulu <[EMAIL PROTECTED]> wrote:
> On Wed, Mar 12, 2008 at 11:36 AM, Mark Webb <[EMAIL PROTECTED]> wrote:
>
> > I would say that it is a valid addition to the BlacklistFilter. No
> > need for duplication.
> >
>
> +1 - we could have used this same feature for various ApacheDS protocols.
>
> Alex
>
>
>
>
> >
> > On Wed, Mar 12, 2008 at 11:31 AM, Niklas Gustavsson
> > <[EMAIL PROTECTED]> wrote:
> > > Hi
> > >
> > > I would like to replace our IpRestrictor implementation in FtpServer
> > > with the BlacklistFilter available in MINA. However, for FtpServer we
> > > would need support for ranges, i.e. 123.45.67.0-123.45.67.123 or
> > > 123.45.0.0-123.45.255.255. Support would be needed both for IP4 and
> > > IP6. Would this be of interest to add in BlacklistFilter? If not, I'll
> > > create a separate implementation for FtpServer.
> > >
> > > /niklas
> > >
> >
> >
> >
> > --
> > --------------------------------
> > Talent hits a target no one else can hit; Genius hits a target no one
> > else can see.
> >
>
