Couple points to make: 1. Why make a blacklist range and a blacklist. Why not just add the range to the blacklist? 2. Should there be more synchronizing of the adding/removing and the check for blocked addresses? What happens if an add and a check for a blocked address happen at the same time?
--Mark On Wed, Mar 12, 2008 at 6:20 PM, Niklas Gustavsson <[EMAIL PROTECTED]> wrote: > On Wed, Mar 12, 2008 at 10:37 PM, Niklas Gustavsson > <[EMAIL PROTECTED]> wrote: > > Cool, so I'll add it and ask for a review when its in SVN. > > Alright, the code is in (rev 636538), have a go at it. I'm particulary > interested in a review of the IP comparison code, not sure I got it > correct. > > /niklas > -- -------------------------------- Talent hits a target no one else can hit; Genius hits a target no one else can see.
