On 17 July 2013 23:49, Jeff MAURY <[email protected]> wrote: > On Thu, Jul 18, 2013 at 12:42 AM, sebb <[email protected]> wrote: > >> On 17 July 2013 23:21, Jeff MAURY <[email protected]> wrote: >> > Build also except if the benchmarks profile is activated: build fails >> > because it seems the benchmarks pom is still on 3.0.0-M1-SNAPSHOT >> >> Both of these files still refer to the SNAPSHOT release: >> >> benchmarks/pom.xml >> benchmarks2/pom.xml >> > benchmarks/pom.xml was the one I was refering. benchmarks2/pom.xml cannot > be updated by the release plugin because it is not referenced by the parent > POM. > >> >> Looks like the release plugin did not work properly, or the poms are >> not configured correctly. >> >> > For the next release, we should put the JDK 7 requirement in the parent >> POM >> > as a requirement : I think Maven will be more explicit >> >> Yes, the Java compiler requirements should be defined using the properties: >> >> maven.compiler.source >> maven.compiler.target >> project.build.sourceEncoding >> >> Can also use >> maven.compiler.debug >> maven.compiler.optimize >> maven.compiler.showDeprecation >> > I was thinking of Maven prequisites ( > http://maven.apache.org/pom.html#Prerequisites) but it only supports Maven > versions. > So we could rather use the enforcer plugin ( > http://maven.apache.org/enforcer/enforcer-rules/requireJavaVersion.html)
Not sure that's necessary for Java 7; the only problem might arise if Java 8 is used to build the code. And that should be obvious from the jar Manifests. > Jeff > >> >> These are picked up automatically by the compiler if not overriden >> >> It's a lot easier to find the settings if they are defined as >> properties rather than buried as compiler config options. >> >> > Jeff >> > >> > >> > >> > On Wed, Jul 17, 2013 at 11:16 PM, Emmanuel Lécharny <[email protected] >> >wrote: >> > >> >> Le 7/17/13 2:33 PM, Emmanuel Lécharny a écrit : >> >> > Hi, >> >> > >> >> > 3rd attempt to cut a release. The binary package now contains just >> what >> >> is needed, and the Nexus repository now contains the release. >> >> > >> >> > >> >> > A temporary tag has been created (it can be removed if the vote is not >> >> approved): >> >> > >> >> > - GIT tag : "mina-parent-3.0.0-M1" SHA-1 : >> >> "35f5b85e65a367dc57eb045b975bfeff5a0bf3cd" >> >> > >> >> > Project: http://git-wip-us.apache.org/repos/asf/mina/repo >> >> > Commit: http://git-wip-us.apache.org/repos/asf/mina/commit/35f5b85e >> >> > Tree: http://git-wip-us.apache.org/repos/asf/mina/tree/35f5b85e >> >> > Diff: http://git-wip-us.apache.org/repos/asf/mina/diff/35f5b85e >> >> > >> >> > >> >> > >> >> > - Nexus repository: >> >> > https://repository.apache.org/content/repositories/orgapachemina-158/ >> >> > >> >> > Let us vote : >> >> > [ ] +1 | Release MINA 3.0.0-M1 >> >> > [ ] +/- | Abstain >> >> > [ ] -1 | Do *NOT* release MINA 3.0.0-M1 >> >> > >> >> > Thanks ! >> >> > >> >> I gorgot to mention that the packages are available at : >> >> >> >> http://people.apache.org/~elecharny/ >> >> >> >> -- >> >> Regards, >> >> Cordialement, >> >> Emmanuel Lécharny >> >> www.iktek.com >> >> >> >> >> > >> > >> > -- >> > Jeff MAURY >> > >> > >> > "Legacy code" often differs from its suggested alternative by actually >> > working and scaling. >> > - Bjarne Stroustrup >> > >> > http://www.jeffmaury.com >> > http://riadiscuss.jeffmaury.com >> > http://www.twitter.com/jeffmaury >> > > > > -- > Jeff MAURY > > > "Legacy code" often differs from its suggested alternative by actually > working and scaling. > - Bjarne Stroustrup > > http://www.jeffmaury.com > http://riadiscuss.jeffmaury.com > http://www.twitter.com/jeffmaury
