On Thu, Dec 17, 2015 at 2:20 PM, Lyor Goldstein <lgoldst...@vmware.com> wrote:
> I think there is @SuppressWarning("javadoc") available... > We don't want that as it will not fix the real problem. Jeff > > -----Original Message----- > From: jeffma...@gmail.com [mailto:jeffma...@gmail.com] On Behalf Of Jeff > MAURY > Sent: Thursday, December 17, 2015 15:17 > To: dev <dev@mina.apache.org> > Subject: Re: MINA build with Java 8 > > Given the Java5 minimum requirement for MINA, can't we have an annotation. > > Jeff > > On Thu, Dec 17, 2015 at 2:08 PM, Emmanuel Lécharny <elecha...@gmail.com> > wrote: > > > Le 17/12/15 13:49, Jeff MAURY a écrit : > > > Agree that we should adopt Java8 standards related to JavaDoc. > > > I think we should have a CI job that does the check from now, even > > > if it fails until we finished what you propose. > > > > Actually, the pb is just when we run mvn site (which makes sense, > > because this is where we build the javadoc). > > > > There are many tags seen as invalid, like : > > > > [ERROR] > > > > > /Users/elecharny/mina/mina/mina-2.0/mina-core/src/main/java/org/apache/mina/core/service/AbstractIoAcceptor.java:131: > > error: unknown tag: org.apache.xbean.Property > > > > ... > > /** > > * A base implementation of {@link IoAcceptor}. > > * > > * @author <a > > href="https://urldefense.proofpoint.com/v2/url?u=http-3A__mina.apache. > > org&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=HMhsGLKXv > > 55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=G2at91n6XJRjtcyuVvVicyab3oTiZElh5 > > 9QAm64_qwQ&s=KY4Wxmwf00ZyM0ciXDyGvUDYc0yB02fpbmyHdTYzHNM&e= ">Apache > > MINA Project</a> > > * @org.apache.xbean.XBean > > */ > > public abstract class AbstractIoAcceptor extends AbstractIoService > > implements IoAcceptor { ... > > > > I'm not sure how we can fix that. > > > > > > > > > -- > Jeff MAURY > > > "Legacy code" often differs from its suggested alternative by actually > working and scaling. > - Bjarne Stroustrup > > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.jeffmaury.com&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=G2at91n6XJRjtcyuVvVicyab3oTiZElh59QAm64_qwQ&s=YxvALbj5IKZc9h_RKWUyEkQIGOHdkfSWlz3eqFHEZdA&e= > > https://urldefense.proofpoint.com/v2/url?u=http-3A__riadiscuss.jeffmaury.com&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=G2at91n6XJRjtcyuVvVicyab3oTiZElh59QAm64_qwQ&s=MmCBiCpSKq5tUCLYwaeDuhPqesPFbXGaylDf-naQ5UE&e= > > https://urldefense.proofpoint.com/v2/url?u=http-3A__www.twitter.com_jeffmaury&d=BQIFaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=HMhsGLKXv55xAmksY4SsQcYP_oPrfu1Vne__JKwWQvo&m=G2at91n6XJRjtcyuVvVicyab3oTiZElh59QAm64_qwQ&s=sgRYQQSaUoCyPfXJFn_suT3QVhrFrVN2o-s3voOe1F4&e= > -- Jeff MAURY "Legacy code" often differs from its suggested alternative by actually working and scaling. - Bjarne Stroustrup http://www.jeffmaury.com http://riadiscuss.jeffmaury.com http://www.twitter.com/jeffmaury