[
https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16564283#comment-16564283
]
ASF GitHub Bot commented on SSHD-838:
-------------------------------------
GitHub user bturner opened a pull request:
https://github.com/apache/mina-sshd/pull/65
SSHD-838 Remove LoggingUtils.logExceptionStackTrace.
- Removed LoggingUtils.logExceptionStackTrace and its related helpers
- Updated call sites in Nio2Acceptor and Nio2Session to log exceptions by
passing them directly to SLF4J
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bturner/mina-sshd
SSHD-838-remove-logexceptionstacktrace
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/mina-sshd/pull/65.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #65
----
commit 4abe76d65227723a91c2073da42eafaa1ef9f5e0
Author: Bryan Turner <bturner@...>
Date: 2018-07-31T19:47:20Z
SSHD-838 Remove LoggingUtils.logExceptionStackTrace.
- Removed LoggingUtils.logExceptionStackTrace and its related helpers
- Updated call sites in Nio2Acceptor and Nio2Session to log exceptions
by passing them directly to SLF4J
----
> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>
> Key: SSHD-838
> URL: https://issues.apache.org/jira/browse/SSHD-838
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: jpalacios
> Priority: Minor
> Attachments: sshd-nio-acceptor-logging.patch
>
>
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it
> appears that when a client disconnects before the handshake completes there's
> some pretty loud logging coming from the
> {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the
> stack trace are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system
> administrators who might think there's something wrong with the system. We
> propose:
> # Changing the log level to {{DEBUG}} / {{FINE}}
> # Logging the stacktrace in a single message
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
