[ 
https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565817#comment-16565817
 ] 

Goldstein Lyor commented on SSHD-838:
-------------------------------------

{quote}
That said, though, I want to be respectful of your time, because I'm not sure I 
personally have the time to devote to building that change, and jpalacios is 
about to leave on vacation
{quote}
I was not implying that you should come up with the code change - I feel I 
understand the requirements and agree with the valid arguments you have made. 
All I ask is that since your project seems to make use of this library, we 
could leverage your experience with it and if possible to map the locations 
where in your experience there is "loud" logging (as you have put it) so I can 
have a better idea as to how to craft the suggested solution and where to 
employ it.

{quote}
and I don't want to assume you have the time to build it either.
{quote}
I am rather busy in the near future, but since I believe this is an important 
issue I will try to find some time for it (don't know when though). Please 
track this issue and if you don't see any progress within the next few weeks, 
please don't hesitate to inquire - just so we can be sure it does not fall 
between the cracks...

> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>
>                 Key: SSHD-838
>                 URL: https://issues.apache.org/jira/browse/SSHD-838
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: jpalacios
>            Priority: Minor
>         Attachments: sshd-nio-acceptor-logging.patch
>
>
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it 
> appears that when a client disconnects before the handshake completes there's 
> some pretty loud logging coming from the 
> {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the 
> stack trace are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system 
> administrators who might think there's something wrong with the system. We 
> propose:
> # Changing the log level to {{DEBUG}} / {{FINE}} 
> # Logging the stacktrace in a single message



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to