[
https://issues.apache.org/jira/browse/SSHD-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565499#comment-16565499
]
Goldstein Lyor commented on SSHD-838:
-------------------------------------
{quote}
That utility feels a lot like fighting the logging framework, to me. Is there
a reason not to just pass the exception object through to SLF4J like "normal"?
{quote}
The reason for it is that when passing the exception directly to the logging
framework it logs the entire stack trace - which is often very long and
tedious. Usually, logging the top (or bottom - depending how you look at it)
6-8 frames provides enough "hints" as to the call flow to let the user know
what went wrong.
{quote}
LoggingUtils.logExceptionStackTrace appears to only be used in 2 places in the
entire codebase
{quote}
This utility is relatively new and we did not retro fit older code.
{quote}
how about removing logExceptionStackTrace
{quote}
If anything, I am considering replacing all code that passes the exception
directly to the logging framework with this call.
> Lower the log level in Nio2Acceptor.AcceptCompletionHandler#okToReaccept
> ------------------------------------------------------------------------
>
> Key: SSHD-838
> URL: https://issues.apache.org/jira/browse/SSHD-838
> Project: MINA SSHD
> Issue Type: Improvement
> Affects Versions: 2.0.0
> Reporter: jpalacios
> Priority: Minor
> Attachments: sshd-nio-acceptor-logging.patch
>
>
> As discussed in [SSHD-833|https://issues.apache.org/jira/browse/SSHD-833], it
> appears that when a client disconnects before the handshake completes there's
> some pretty loud logging coming from the
> {{Nio2Acceptor.AcceptCompletionHandler#okToReaccept}}.
> The entire message is logged at {{WARN}} level. Also, several lines from the
> stack trace are logged individually at the same level.
> We feel this much logging at {{WARN}} level will be too much noise for system
> administrators who might think there's something wrong with the system. We
> propose:
> # Changing the log level to {{DEBUG}} / {{FINE}}
> # Logging the stacktrace in a single message
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
