[
http://jira.codehaus.org/browse/MNBMODULE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241889#action_241889
]
Jesse Glick commented on MNBMODULE-113:
---------------------------------------
Do you have a clean patch for this against current trunk? No reformatting of
existing code, no moving code into a new method like generateBrandingJnlp
(unless necessary to avoid duplication), no changes for other bugs, just a
minimal diff. I would like to get 3.4 released and this is the last thing in
the queue.
Just to be sure I understand the problem being solved: the NB main frame
already shows the correct icon, yes? So this only affects (1) the JNLP splash
screen briefly shown, (2) the icon used for any JNLP desktop shortcut?
BTW thank you for using 'svn diff' on this patch; in other patches you seem to
be using the IDE's "Create Patch" menu item, which is basically broken and
should never be used.
> Use branding icon and splash icons in jws
> -----------------------------------------
>
> Key: MNBMODULE-113
> URL: http://jira.codehaus.org/browse/MNBMODULE-113
> Project: Maven NetBeans Module Plugin
> Issue Type: Improvement
> Affects Versions: 3.4
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Priority: Minor
> Attachments: brandingIcons.diff
>
>
> So far the icon used for a JWS nb app is master.jnlp expected in the target
> folder, which is cleaned.
> The branding icon and splash are not used.
> Attached path uses the splash, which is expected in branding resources as
> well as the icon image (frame32).
> Tested on two projects:
> 1. new maven project from dev ide.
> 2. memorizeasy.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
