[
http://jira.codehaus.org/browse/MNBMODULE-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=241960#action_241960
]
Jesse Glick commented on MNBMODULE-113:
---------------------------------------
It is easy to watch for reformatting of existing code - look at the patch
before you attach it, and if there are any lines which do not clearly and
directly relate to the stated bug fix, revert them and regenerate. I only
review and apply clean, minimal diffs against current trunk - otherwise it is
easier and safer to just fix the bug myself, when the problem is well
understood.
#3 I probably cannot verify for myself since I have no access to a Mac; I
assume that you are testing that specifying a shortcut icon works for this
purpose on a Mac as well.
"According to the specification only jpeg and gif are allowed." - "or other
(possibly platform dependant) formats" is what it then says; I think using PNG
should be fine in practice, if that is what the app's icon is to begin with.
"the developer needs to place the icon image in the webstart folder which is
emptied at each build" - if you want to work around a missing file in the
target/webstart folder I think you would do this with some kind of copy goal so
that it is run automatically during the build.
> Use branding icon and splash icons in jws
> -----------------------------------------
>
> Key: MNBMODULE-113
> URL: http://jira.codehaus.org/browse/MNBMODULE-113
> Project: Maven NetBeans Module Plugin
> Issue Type: Improvement
> Affects Versions: 3.4
> Reporter: Gabriele Kahlout
> Assignee: Jesse Glick
> Priority: Minor
> Attachments: brandingIcons.diff
>
>
> So far the icon used for a JWS nb app is master.jnlp expected in the target
> folder, which is cleaned.
> The branding icon and splash are not used.
> Attached path uses the splash, which is expected in branding resources as
> well as the icon image (frame32).
> Tested on two projects:
> 1. new maven project from dev ide.
> 2. memorizeasy.com
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe from this list, please visit:
http://xircles.codehaus.org/manage_email
