hi, - I think you should rename the goal main-jslint to jslint, without this
prefix it's already clear it is for the main sources.- I'm missing a clear
description of this plugin. I don't know jslint, but I guess it has to do with
javascript. From the first page I don't see if it will optimize the code or
generate a report or something else...- So it seems it reports to the console?
Don't we want to generate reports as well to be available during site
generation?- Could it be compared with the m-checkstyle-p[1]? It has two goals:
_checkstyle_ for the report and _check_ to validate it. Same counts for pmd[2].
Looks to me you've written the check mojo, not yet the reports (this conflicts
a bit with my first bullet, but I think you understand) I think it would indeed
be a nice plugin, but IMHO there are a few things which need to be changed to
let it look more like equivalent plugins (which makes it easier to understand
for users)So I'd say -1 for a 1.0.0, but for a beta-1 I'd be happy to give a +1
-Robert [1] http://maven.apache.org/plugins/maven-checkstyle-plugin/[2]
http://maven.apache.org/plugins/maven-pmd-plugin/> Date: Fri, 19 Aug 2011
09:54:24 +0200
> From: [email protected]
> CC: [email protected]
> Subject: Re: [mojo-dev] [vote] Graduate the Maven JSLint Plugin version
> 1.0.0-SNAPSHOT
>
> On Fri, 19 Aug 2011 09:05:56 +0200
> Anders Hammar <[email protected]> wrote:
>
> Here is my +1 , look also fine to me.
>
> tony.
>
> > I now thinks everything looks good, so here's my +1!
> >
> > For superior Eclipse experience, a m2e connector should also be
> > developed. But that's outside of Mojo's scope.
> >
> > /Anders
> >
> > On Fri, Aug 19, 2011 at 08:54, Christopher Hunt
> > <[email protected]> wrote:
> > > Hi Anders,
> > >
> > > I've refreshed the site - all good now. Also updated the Mojo dev
> > > guidelines with respect to the groupId.
> > >
> > > I've not removed the old site yet. Can you give me a quick pointer
> > > on how to do that? My brain is frazzled and I've got to leave work
> > > very shortly…
> > >
> > > Kind regards,
> > > Christopher
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe from this list, please visit:
> > >
> > > http://xircles.codehaus.org/manage_email
> > >
> > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe from this list, please visit:
> >
> > http://xircles.codehaus.org/manage_email
> >
> >
>
>
>
> --
> Tony Chemit
> --------------------
> tél: +33 (0) 2 40 50 29 28
> email: [email protected]
> http://www.codelutin.com
>
> ---------------------------------------------------------------------
> To unsubscribe from this list, please visit:
>
> http://xircles.codehaus.org/manage_email
>
>
