Hi Robert, On 19/08/2011, at 7:59 PM, Robert Scholte wrote:
> - I think you should rename the goal main-jslint to jslint, without this > prefix it's already clear it is for the main sources. OK. > - I'm missing a clear description of this plugin. I don't know jslint, but I > guess it has to do with javascript. From the first page I don't see if it > will optimize the code or generate a report or something else… I shall do my best to enhance the description, but really the idea is that you already know about JSLint given Doug Crockford's in infamy and you're looking to integrate it with your build. > - So it seems it reports to the console? Don't we want to generate reports as > well to be available during site generation? Nope. Compare this more with the Java Compiler Plugin. You save a file and you want to see whether you've got syntax errors etc. > - Could it be compared with the m-checkstyle-p[1]? It has two goals: > _checkstyle_ for the report and _check_ to validate it. Same counts for > pmd[2]. Looks to me you've written the check mojo, not yet the reports (this > conflicts a bit with my first bullet, but I think you understand) I don't see the reporting goal as being useful; in the same way that there's no reporting for the Java compiler plugin. > > I think it would indeed be a nice plugin, but IMHO there are a few things > which need to be changed to let it look more like equivalent plugins (which > makes it easier to understand for users) > So I'd say -1 for a 1.0.0, but for a beta-1 I'd be happy to give a +1 I'll take that as a +1 then, 'cause all I'm looking for right now is a vote on graduation from the sandbox! Thanks. Kind regards, Christopher
