On Fri, 17 Jan 2014 09:51:05 +0100 Anders Hammar <and...@hammar.net> wrote:
> The vote mail says that there were 2 solved issues, but the release notes > lists 3. > MOJO-2002 is marked "won't fix" but there was actually some change applied > which is wrong. Does it really matters ? for people using the mojo-parent I don't think so. I mark a issue as *Won't fix*? so for me 2 issues are solved, is this wrong? > As part of MOJO-2002 there were some changes that were reverted, but there > is still some incorrect comments left in the pom and there is configuration > for the enforcer plugin which is commented out. I don't think that's ok > either. Either we use a rule or it should be removed. The scm can be used > if we want to go back and view some old code. And all comments should be > correct. Yes The comment on the prerequisite is perharps not so correct. but for the enforcer-rule, there is a comment, once again IMHO As a mojo dev (I don't pass my day reading the mojo-parent code; I just want to use it, no?). What was the problem for me is to not be able to make a release with the last mojo-parent (site generation is not ok). This is a real blocker; not a comment in a pom... But I can still understand you want mojo-parent perfect. > > I guess we could change MOJO-2002 to "fixed" and then create a separate > ticket to fix the remaining unwanted changes for the next version. However, > we would then have a change in what phase the enforcer plugin runs which I > don't know is intentional (although makes sense). The latter could be > handled by creating a new ticket for this change. Could you then do this I am a bit lost with what you want to do?. I would just want to use a new mojo-parent with correct MOJO-1946 thanks, tony. -- Tony Chemit -------------------- tél: +33 (0) 2 40 50 29 28 http://www.codelutin.com email: che...@codelutin.com twitter: https://twitter.com/tchemit --------------------------------------------------------------------- To unsubscribe from this list, please visit: http://xircles.codehaus.org/manage_email
