Sheng, thanks for clarification. That make sense to me. I will change the vote
to +1
>
> On Sep 2, 2018 at 9:43 AM, <Sheng Zha (mailto:zhash...@apache.org)> wrote:
>
>
>
> Hi Steffen and Zhi,
>
> That's because those are not the artifacts being voted on. I just uploaded
> the actual release artifact to [1]. Unfortunately, even the lengthy release
> process doc [2] didn't capture this step...
>
> Steffen,
>
> In case you don't already know, regarding the version string, since we cannot
> change the code after the vote passes, the version never says it's a release
> candidate, only the file name does. None of the previous releases follow the
> convention you suggested. Please adjust your expectation and vote again. Feel
> free to download previous releases and verify:
>
> % tar -zxf apache-mxnet-src-1.2.1.rc1-incubating.tar.gz -O
> apache-mxnet-src-1.2.1.rc1-incubating/python/mxnet/libinfo.py | grep
> '__version__'
> __version__ = "1.2.1"
>
> Zhi,
>
> We are not accepting new patches after the announced cutoff time. If you
> think this patch is optional and you see no other issue with this release,
> consider changing your vote. If you think the patch is critical, feel free to
> sustain your -1 vote until the end of this voting cycle.
>
> [1]
> https://github.com/apache/incubator-mxnet/releases/download/1.3.0.rc0/apache-mxnet-src-1.3.0.rc0-incubating.tar.gz
>
> [2] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=73630468
>
>
> -sz
>
> On 2018/09/01 22:08:48, "Joshua Z. Zhang" <cheungc...@gmail.com> wrote:
> > -1. Please include all 3rd party dependencies, GitHub won’t automatically
> > do that.
> >
> > BTW, Per user request in forum, I found this
> > PR(https://github.com/apache/incubator-mxnet/pull/12118
> > <https://github.com/apache/incubator-mxnet/pull/12118>) is not included in
> > 1.3 rc0, I recommend to cherry-pick into release to avoid potential
> > problems.
> >
> > Best,
> > Zhi
> > > On Sep 1, 2018, at 2:27 PM, Steffen Rochel <steffenroc...@gmail.com>
> > wrote:
> > >
> > > -1
> > >
> > > https://github.com/apache/incubator-mxnet/archive/1.3.0.rc0.zip and
> > > https://github.com/apache/incubator-mxnet/archive/1.3.0.rc0.tar.gz do
> > not
> > > contain 3rdparty packages, resulting in make failure:
> > > tar zxf incubator-mxnet-1.3.0.rc0.tar.gz
> > > cd incubator-mxnet-1.3.0.rc0/
> > > make USE_OPENCV=1 USE_BLAS=openblas
> > > Makefile:74:
> > >
> > /home/steffen/Downloads/incubator-mxnet-1.3.0.rc0/3rdparty/mshadow/make/
> > > mshadow.mk: No such file or directory
> > > Makefile:75:
> > >
> > /home/steffen/Downloads/incubator-mxnet-1.3.0.rc0/3rdparty/dmlc-core/make/
> > > dmlc.mk: No such file or directory
> > > Makefile:176: "USE_LAPACK disabled because libraries were not found"
> > > Makefile:284: WARNING: Significant performance increases can be
> > achieved by
> > > installing and enabling gperftools or jemalloc development packages
> > > Makefile:355:
> > >
> > /home/steffen/Downloads/incubator-mxnet-1.3.0.rc0/3rdparty/ps-lite/make/
> > > ps.mk: No such file or directory
> > > make: *** No rule to make target
> > >
> > '/home/steffen/Downloads/incubator-mxnet-1.3.0.rc0/3rdparty/ps-lite/make/
> > > ps.mk'. Stop.
> > >
> > > ~/Downloads/incubator-mxnet-1.3.0.rc0/3rdparty$ ls -al *
> > > cub:
> > > total 8
> > > drwxr-xr-x 2 steffen steffen 4096 Aug 29 10:07 .
> > > drwxr-xr-x 12 steffen steffen 4096 Aug 29 10:07 ..
> > >
> > > dlpack:
> > > total 8
> > > drwxr-xr-x 2 steffen steffen 4096 Aug 29 10:07 .
> > > drwxr-xr-x 12 steffen steffen 4096 Aug 29 10:07 ..
> > >
> > > dmlc-core:
> > > total 8
> > > drwxr-xr-x 2 steffen steffen 4096 Aug 29 10:07 .
> > > drwxr-xr-x 12 steffen steffen 4096 Aug 29 10:07 ..
> > >
> > > Environment:
> > > uname -a
> > > Linux steffen 4.15.0-33-generic #36-Ubuntu SMP Wed Aug 15 16:00:05 UTC
> > 2018
> > > x86_64 x86_64 x86_64 GNU/L
> > >
> > > Build from git succeeded:
> > > git clone --recursive https://github.com/apache/incubator-mxnet
> > --branch
> > > 1.3.0.rc0
> > > cd incubator-mxnet/
> > > git checkout 1.3.0.rc0
> > > make USE_OPENCV=1 USE_BLAS=openblas
> > > cd python/
> > > sudo pip install -e .
> > >
> > >>>> import mxnet as mx
> > >>>> print(mx.__version__)
> > > 1.3.0
> > >
> > > I was expecting version to be 1.3.0.rc0
> > >
> > > Steffen
> > >
> > >
> > >
> > > On Sat, Sep 1, 2018 at 3:22 AM Pigeon Lucky <lucky90...@gmail.com>
> > wrote:
> > >
> > >> +1
> > >>
> > >> On Sat, 1 Sep 2018, 10:59 Roshani Nagmote,
> > <roshaninagmo...@gmail.com>
> > >> wrote:
> > >>
> > >>> Hi all,
> > >>>
> > >>> I would like to propose a vote to release Apache MXNet (incubating)
> > >> version
> > >>> 1.3.0.RC0. Voting will start now (Friday, Aug 31st) and end at 7:00
> > PM
> > >>> PDT, Wednesday, Sept 5th.
> > >>>
> > >>> Link to release notes:
> > >>> https://github.com/apache/incubator-mxnet/releases
> > >>>
> > >>> Link to release candidate 1.3.0.rc0:
> > >>> *https://github.com/apache/incubator-mxnet/releases/tag/1.3.0.rc
> > >>>
> > <https://github.com/apache/incubator-mxnet/releases/tag/1.3.0.rc0>0*
> > >>>
> > >>> View this page, click on "Build from Source", and use the source
> > code
> > >>> obtained from 1.3.0.rc0 tag:
> > >>> https://mxnet.incubator.apache.org/install/index.html
> > >>>
> > >>> Please remember to TEST first before voting accordingly:
> > >>>
> > >>> +1 = approve
> > >>> +0 = no opinion
> > >>> -1 = disapprove (provide reason)
> > >>>
> > >>> Thanks,
> > >>> Roshani
> > >>>
> > >>
> >
> >
>
