Sandeep mentions the issue of an error when user tries to load model params trained/saved as FP16. https://github.com/apache/incubator-mxnet/issues/11849 The fix was done by Sandeep: https://github.com/apache/incubator-mxnet/pull/12412 and is ready to be cherry picked into the release branch.
This seems like a release blocker to me: - Basic functionality broken: loading a model (albeit one that that was saved as non FP32) - Reported by 3 users (wgchang@, nicklhy@ and ThomasDelteil@) -1 (non binding) Hagay On Tue, Sep 4, 2018 at 12:01 PM sandeep krishnamurthy < sandeep.krishn...@gmail.com> wrote: > "- 0" > > I believe the bug #11849 > <https://github.com/apache/incubator-mxnet/issues/11849>, unable to import > non-fp32 models into Gluon, fixed in this PR #12412 > <https://github.com/apache/incubator-mxnet/pull/12412> is important for > the > users. I would rather pick this fix in this release than plan a minor > release later. > > Best, > Sandeep > > > > On Mon, Sep 3, 2018 at 2:34 PM Philip Cho <chohy...@cs.washington.edu> > wrote: > > > Actually, the command "git clone --recursive > > https://github.com/apache/incubator-mxnet -b 1.3.0.rc0" works fine now, > > never mind. > > > > On Mon, Sep 3, 2018 at 1:45 PM Philip Cho <chohy...@cs.washington.edu> > > wrote: > > > > > Unfortunately, MXNet was depending on a branch of TVM that is now > > deleted. > > > We will have to merge #12448 > > > <https://github.com/apache/incubator-mxnet/pull/12448> before the > > release. > > > > > > Background: See dmlc/tvm#1394 <https://github.com/dmlc/tvm/issues/1394 > >. > > > > > > Philip. > > > > > > On Mon, Sep 3, 2018 at 7:26 AM Carin Meier <carinme...@gmail.com> > wrote: > > > > > >> Checked out the tag, built and tested the Clojure package. +1 > > >> > > >> On Fri, Aug 31, 2018 at 10:59 PM Roshani Nagmote < > > >> roshaninagmo...@gmail.com> > > >> wrote: > > >> > > >> > Hi all, > > >> > > > >> > I would like to propose a vote to release Apache MXNet (incubating) > > >> version > > >> > 1.3.0.RC0. Voting will start now (Friday, Aug 31st) and end at 7:00 > PM > > >> > PDT, Wednesday, Sept 5th. > > >> > > > >> > Link to release notes: > > >> > https://github.com/apache/incubator-mxnet/releases > > >> > > > >> > Link to release candidate 1.3.0.rc0: > > >> > *https://github.com/apache/incubator-mxnet/releases/tag/1.3.0.rc > > >> > <https://github.com/apache/incubator-mxnet/releases/tag/1.3.0.rc0 > >0* > > >> > > > >> > View this page, click on "Build from Source", and use the source > code > > >> > obtained from 1.3.0.rc0 tag: > > >> > https://mxnet.incubator.apache.org/install/index.html > > >> > > > >> > Please remember to TEST first before voting accordingly: > > >> > > > >> > +1 = approve > > >> > +0 = no opinion > > >> > -1 = disapprove (provide reason) > > >> > > > >> > Thanks, > > >> > Roshani > > >> > > > >> > > > > > > > > -- > Sandeep Krishnamurthy >
