On 1/7/06, Martin Marinschek <[EMAIL PROTECTED]> wrote: > I have started looking at the sources, > > and my first look was on the accompanying java-script code. > > Now, I hope Martin Cooper hasn't had the time to look so far, cause he > wouldn't have been to happy ;) > > Issues I've seen so far: > > - no namespacing for class-names > - global variables (not even namespaced) > - global, not namespaced functions
Yeah, known - when this code was written (it pretty much all comes from UIX) we were very naive JS developers. One of the items already on our todo list is moving all the functions, classes, and variables inside a single top level object. > apart from that, the javascript code in the functions themselves > looked pretty decent to me. Any chance we can work together to clean > that up in incubator? Absolutely! (Incubator, sandbox, whereever...) -- Adam > regards, > > Martin > > On 1/7/06, Matthias Wessendorf <[EMAIL PROTECTED]> wrote: > > Adam, John. > > > > this is a good news. Nice to hear! > > > > > This should be (nearly) a fully buildable Maven 2.0 project, > > > including a separate project of custom Maven 2 plugins ( > > > which are also part of the contribution.) There's an Apache 2.0 > > > LICENSE.txt at the root of the distribution, and to save people > > > the work of building it, we've included the JARs and our > > > demo WAR. > > > > Very good! This is *convenient* for a lot`s of user, which want to > > play fast w/ ADF components. I also deployed the WAR before I started > > looking at the sources ;-) > > > > > - Our tests use a Mock JSF impl that's just a mockmaker > > > run over jsf-api - but that's not totally ASF-legit. > > > We've included that jar in this distribution, but this needs > > > to be redone the right way. > > > > so... is this jar non-asf compatible? If yes... I guess Ted can't > > upload the zip to the p.a.o server. Correct me, if I am wrong. > > > > -Matthias > > > > > Looking forward to all of your comments! > > > > > > Best regards, > > > John and Adam > > > > > > > > > -- > > Matthias Wessendorf > > Zülpicher Wall 12, 239 > > 50674 Köln > > http://www.wessendorf.net > > mwessendorf-at-gmail-dot-com > > > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces >
