quick comment inside On Fri, Oct 16, 2009 at 8:25 AM, Martin Kočí <martin.k...@aura.cz> wrote: > Hi, > > please review simple patch > https://issues.apache.org/jira/browse/TRINIDAD-1596. > > More question about Resource support in trinidad2: > > 1) JSF 2 introduced "name" and "library" as an alternative to "src", > "image" or "icon" for example. According to tag library documentation > there is support only on h:graphicImage, but surprisingly it works with > h:commandButton too (and maybe other). > > Should trinidad support name and library with tr:image (an alternative > to h:graphicImage)? > > If a component has exactly one image attribute ("icon" in trinidad) > interpret name/library as alternative to it ? I think "name" and > "library" are too generic - they should be named "iconName" and > "iconLibrary" or something like that. > > Folowing components have icon attribute: > CoreInputListOfValues > CorePanelBox > CorePanelHeader > CorePanelPopup > CoreShowDetailHeader > CoreCommandButton > CoreCommandNavigationItem > CoreGoButton > > I dont really understand if name/library concept was intended for > components without behaviour from 'resource' family like image or CSS. > > 2) HTML head section > There are h:outputStylesheet and h:outputScript in JSF 2.0 . Both > support name and library attrs too. If we will rework trinidad2 to > Resource API is there any reason why add to trh:styleSheeet > name/library support? > I think trh: tags can remain for JSP/old application and without > name/library attrs and for new trinidad2/Facelets based application > users can use new tags from JSF 2.0
I need to go deeper into the research on Resource Handling, and its impact on Trinidad. Will probably start on this by Monday.. One thing I noticed as well is that you have to target the location (head/body). Trinidad should not require the h:head/body; instead we should use the head/body section w/in the tr:document (which is basically using the head/body tags from trh) -Matthias > > Note: name/library are only a option to #{resource} implicit object. > > > Regards, > > Martin > > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf