which means we are good to go, since nothing was copied ;-) +1
On Tue, Mar 2, 2010 at 4:16 PM, Matthias Wessendorf <mat...@apache.org> wrote: > that would qualify the patch as -1 > > On Tue, Mar 2, 2010 at 4:14 PM, Max Starets <max.star...@oracle.com> wrote: >> Matthias, >> >> And one more thing - no Sun RI code was copied. >> >> Max >> >> Matthias Wessendorf wrote: >> >> -1 on the patch. >> >> We really can't use license header from LGPL2code...: >> -InternalViewHandlingStrategy >> -ViewDeclarationLanguageFactoryImpl >> >> Nor can't we copy code from the SUN RI to Apache. >> >> -Matthias >> >> >> On Tue, Mar 2, 2010 at 1:40 AM, Max Starets <max.star...@oracle.com> wrote: >> >> >> Gary, >> No, this just sn internal reorganization, and there will be no API changes. >> Max >> >> On Mar 1, 2010, at 7:04 PM, Gary Kind <gary.k...@oracle.com> wrote: >> >> Will this affect the Controller team? >> >> Gary Kind >> >> Max Starets wrote: >> >> Hello Everyone, >> >> While I was working on a solution for TRINIDAD-1735, I realized that the >> clean solution >> would involve moving all the code dealing with InternalViews from the >> ViewHandlerImpl to >> the new ViewDeclarationLanguageFactoryImpl. We also would expose a special >> VDL for the internal >> views, which is what Martin Koci suggested a while ago. >> >> Pleas review the jira and the associated patch. If there are no objections, >> I will commit the change in >> a few days. >> >> Thanks, >> Max >> >> >> >> >> >> > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
