Leo,
I've been looking in some test failures that we're seeing with the 2.0.1
snapshot builds, and I think I've found one that we really need to
resolve for 2.0.1. I'm about to open a JIRA issue but wanted to give
you a heads up on this thread.
With the new javascript, we now wrapper jsf.ajax.request with a function
call. So for example this:
<h:commandButton id="incrementButton" value="Increment"
onclick="jsf.ajax.request(this, event, {
execute: this.id, render: 'counter' }); return false;"
actionListener="#{counter.increment}" />
would be rendered as this:
<input id="incrementButton" name="incrementButton" type="submit"
value="Increment"
onclick="var cf = function(){jsf.ajax.request(this, event, { execute:
this.id, render: 'counter' }); return false;};var oamSF =
function(){};return (cf()==false)? false : oamSF();" />
The problem is that by doing this we've broken the reference to this.id
as it is undefined at the function's scope. This works fine in both the
2.0.0 release as well as Mojarra so it will regress anyone who might be
using this.
Regards,
Mike
On 6/15/2010 5:14 PM, Leonardo Uribe wrote:
Hi Bernd
I added in api:
META-INF/licenses/dojo-LICENSE.TXT
META-INF/licenses/j4fry-LICENSE.TXT
META-INF/licenses/facelets-LICENSE.TXT
in impl
META-INF/licenses/glassfish-LICENSE.TXT
META-INF/licenses/facelets-LICENSE.TXT
because the schemas with CDDL license are on impl jar.
The update to NOTICE.txt message was committed too. Anyway to prevent
misunderstandings, I'll wait your response about it.
regards,
Leonardo Uribe
2010/6/15 Bernd Bohmann <bernd.bohm...@atanion.com
<mailto:bernd.bohm...@atanion.com>>
Hello Leonardo,
looks ok for me.
Can you also add in api
META-INF/licenses/dojo-LICENSE.TXT
META-INF/licenses/j4fry-LICENSE.TXT
META-INF/licenses/glassfish-LICENSE.TXT
META-INF/licenses/facelets-LICENSE.TXT
and in impl
META-INF/licenses/facelets-LICENSE.TXT
an example would be
http://svn.apache.org/repos/asf/myfaces/tomahawk/trunk/core/src/main/resources/META-INF/licenses/
I have no time to perform the required changes unit tomorrow
afternoon.
Regards
Bernd
On Tue, Jun 15, 2010 at 8:11 PM, Leonardo Uribe <lu4...@gmail.com
<mailto:lu4...@gmail.com>> wrote:
> Hi
>
> I think the NOTICE.txt file on impl module could be like this:
>
> This product includes software developed by:
> The Apache Software Foundation (http://www.apache.org/).
>
>
------------------------------------------------------------------------
> See the file LICENSE.txt
> See licenses for accompanying products in the "/licenses"
subdirectory.
>
------------------------------------------------------------------------
>
> This software also includes code from Facelets
> (https://facelets.dev.java.net/)
> for the purpose of implementing Facelets PDL for JSF 2.0 support.
>
> This product includes schema files developed for the Glassfish
Java EE
> reference implementation (http://java.sun.com/xml/ns/j2ee/).
> Apache Myfaces elects to include this software in this distribution
> under the CDDL license. You can obtain a copy of the License at:
> https://glassfish.dev.java.net/public/CDDL+GPL.html
> The source code is available at:
> https://glassfish.dev.java.net/source/browse/glassfish/
>
> The following schemas are included:
>
> ===========================
> javaee_5.xsd
> javaee_web_services_client_1_2.xsd
> ===========================
>
> If no comments, I'll commit this fix tomorrow, regenerate all
artifacts and
> start vote again.
>
> regards,
>
> Leonardo Uribe
>
> 2010/6/15 Leonardo Uribe <lu4...@gmail.com
<mailto:lu4...@gmail.com>>
>>
>> Ok, let me know when all fixes has been applied, so I can
regenerate
>> (again) the artifacts.
>>
>> To prevent misunderstandings, it is better to propose another
vote and
>> after that wait another 72 hours for release.
>>
>> 2010/6/15 Mike Kienenberger <mkien...@gmail.com
<mailto:mkien...@gmail.com>>
>>>
>>> The licensing issue has to be fixed, if there is such an issue.
>>> And Bernd needs to withdraw his -1 before we can release using
this vote.
>>>
>>> On Tue, Jun 15, 2010 at 12:30 PM, Leonardo Uribe
<lu4...@gmail.com <mailto:lu4...@gmail.com>>
>>> wrote:
>>> >
>>> > 2010/6/15 Mike Kienenberger <mkien...@gmail.com
<mailto:mkien...@gmail.com>>
>>> >>
>>> >> At this point, should this discussion be moved out of the
voting
>>> >> thread?
>>> >>
>>> >> By the way, MyFaces can include CDDL xsd and dtd spec
files, so long
>>> >> as they are appropriately documented.
>>> >>
>>> >> http://www.apache.org/legal/resolved.html#category-b
>>> >>
>>> >
>>> > So we can close this vote and continue the release
procedure, right?
>>> >
>>> >>
>>> >> On Tue, Jun 15, 2010 at 12:02 PM, Leonardo Uribe
<lu4...@gmail.com <mailto:lu4...@gmail.com>>
>>> >> wrote:
>>> >> > Hi
>>> >> >
>>> >> > Those files were copied from tomcat project:
>>> >> >
>>> >> >
>>> >> >
>>> >> >
http://svn.apache.org/repos/asf/tomcat/trunk/java/javax/servlet/resources/
>>> >> >
>>> >> > There is no mention in NOTICE file there.
>>> >> >
>>> >> > regards,
>>> >> >
>>> >> > Leonardo Uribe
>>> >> >
>>> >> > 2010/6/15 Bernd Bohmann <bernd.bohm...@atanion.com
<mailto:bernd.bohm...@atanion.com>>
>>> >> >>
>>> >> >> Hello,
>>> >> >>
>>> >> >> the geronimo project includes these file as well. See:
>>> >> >>
>>> >> >> http://svn.apache.org/repos/asf/geronimo/server/trunk/NOTICE
>>> >> >>
>>> >> >> Maybe we should follow with the same procedure.
>>> >> >>
>>> >> >> Any suggestions?
>>> >> >>
>>> >> >> Regards
>>> >> >>
>>> >> >> Bernd
>>> >> >>
>>> >> >>
>>> >> >>
>>> >> >> On Tue, Jun 15, 2010 at 10:06 AM, Werner Punz
>>> >> >> <werner.p...@gmail.com <mailto:werner.p...@gmail.com>>
>>> >> >> wrote:
>>> >> >> > Hi, sorry to be nitpicking again, but since both files
are CDDL
>>> >> >> > are
>>> >> >> > we
>>> >> >> > even
>>> >> >> > allowed to bundle them?
>>> >> >> > Or are both clear due to reimplementation and this was
an error
>>> >> >> > made
>>> >> >> > on
>>> >> >> > Bernds side.
>>> >> >> >
>>> >> >> >
>>> >> >> > Werner
>>> >> >> >
>>> >> >> >
>>> >> >> >
>>> >> >> > Am 14.06.10 19:57, schrieb Leonardo Uribe:
>>> >> >> >>
>>> >> >> >> Hi Bernd
>>> >> >> >>
>>> >> >> >> All artifacts has been regenerated, to include your
fix, so we
>>> >> >> >> can
>>> >> >> >> continue with the vote.
>>> >> >> >>
>>> >> >> >> regards,
>>> >> >> >>
>>> >> >> >> Leonardo Uribe
>>> >> >> >>
>>> >> >> >> 2010/6/13 Bernd Bohmann <bernd.bohm...@googlemail.com
<mailto:bernd.bohm...@googlemail.com>
>>> >> >> >> <mailto:bernd.bohm...@googlemail.com
<mailto:bernd.bohm...@googlemail.com>>>
>>> >> >> >>
>>> >> >> >> Hello,
>>> >> >> >>
>>> >> >> >> here is my
>>> >> >> >>
>>> >> >> >> -1
>>> >> >> >>
>>> >> >> >> I found too many files without or old apache
license header.
>>> >> >> >> j4fry is missing in the notice file.
>>> >> >> >>
>>> >> >> >> The files
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
core/impl/src/main/resources/org/apache/myfaces/resource/javaee_5.xsd
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
core/impl/src/main/resources/org/apache/myfaces/resource/javaee_web_services_client_1_2.xsd
>>> >> >> >> are cddl and are missing in the notice file
>>> >> >> >>
>>> >> >> >> I have tried to fix some of the errors in the
trunk and in
>>> >> >> >> the
>>> >> >> >> 2.0.1
>>> >> >> >> branch.
>>> >> >> >>
>>> >> >> >> Regards
>>> >> >> >>
>>> >> >> >> Bernd
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >> On Sun, Jun 13, 2010 at 10:57 AM, Mark Struberg
>>> >> >> >> <strub...@yahoo.de <mailto:strub...@yahoo.de>
>>> >> >> >> <mailto:strub...@yahoo.de
<mailto:strub...@yahoo.de>>> wrote:
>>> >> >> >> > +0 the artifacts look good so far, but I was not
able to
>>> >> >> >> build
>>> >> >> >> them from the source distribution.
>>> >> >> >> >
>>> >> >> >> > LieGrue,
>>> >> >> >> > strub
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> > --- On Fri, 6/11/10, Leonardo Uribe
<lu4...@gmail.com <mailto:lu4...@gmail.com>
>>> >> >> >> <mailto:lu4...@gmail.com <mailto:lu4...@gmail.com>>>
wrote:
>>> >> >> >> >
>>> >> >> >> > From: Leonardo Uribe <lu4...@gmail.com
<mailto:lu4...@gmail.com>
>>> >> >> >> <mailto:lu4...@gmail.com <mailto:lu4...@gmail.com>>>
>>> >> >> >> > Subject: [VOTE] release for myfaces core 2.0.1
>>> >> >> >> > To: "MyFaces Development" <dev@myfaces.apache.org
<mailto:dev@myfaces.apache.org>
>>> >> >> >> <mailto:dev@myfaces.apache.org
<mailto:dev@myfaces.apache.org>>>
>>> >> >> >> > Date: Friday, June 11, 2010, 7:06 PM
>>> >> >> >> >
>>> >> >> >> > Hi,
>>> >> >> >> >
>>> >> >> >> > I was running the needed tasks to get the 2.0.1
release of
>>> >> >> >> Apache
>>> >> >> >> > MyFaces core out.
>>> >> >> >> >
>>> >> >> >> > The artifacts passed all TCK tests.
>>> >> >> >> >
>>> >> >> >> > Please note that this vote concerns all of the
following
>>> >> >> >> parts:
>>> >> >> >> > 1. Maven artifact group "org.apache.myfaces.shared"
>>> >> >> >> v4.0.2
>>> >> >> >> [1]
>>> >> >> >> >
>>> >> >> >> > 2. Maven artifact group "org.apache.myfaces.core"
v2.0.1
>>> >> >> >> [1]
>>> >> >> >> > 3. Maven artifact group "org.apache.myfaces.test"
>>> >> >> >> v1.0.0-beta-4
>>> >> >> >> [1]
>>> >> >> >> >
>>> >> >> >> > The artifacts are deployed to my private Apache account
>>> >> >> >> ([1]
>>> >> >> >> and
>>> >> >> >> [3] for binary and source packages).
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> > The release notes could be found at [4].
>>> >> >> >> >
>>> >> >> >> > Also the clirr test does not show binary
incompatibilities
>>> >> >> >> with
>>> >> >> >> myfaces-api.
>>> >> >> >> >
>>> >> >> >> > Please take a look at the "2.0.1" artifacts and vote!
>>> >> >> >> >
>>> >> >> >> > Please note: This vote is "majority approval" with a
>>> >> >> >> minimum
>>> >> >> >> of
>>> >> >> >> three
>>> >> >> >> >
>>> >> >> >> > +1 votes (see [3]).
>>> >> >> >> >
>>> >> >> >> > ------------------------------------------------
>>> >> >> >> > [ ] +1 for community members who have reviewed the bits
>>> >> >> >> > [ ] +0
>>> >> >> >> > [ ] -1 for fatal flaws that should cause these bits
not to
>>> >> >> >> be
>>> >> >> >> released,
>>> >> >> >> >
>>> >> >> >> > and why..............
>>> >> >> >> > ------------------------------------------------
>>> >> >> >> >
>>> >> >> >> > Thanks,
>>> >> >> >> > Leonardo Uribe
>>> >> >> >> >
>>> >> >> >> > [1] http://people.apache.org/~lu4242/myfaces201
<http://people.apache.org/%7Elu4242/myfaces201>
>>> >> >> >> <http://people.apache.org/%7Elu4242/myfaces201>
>>> >> >> >> >
>>> >> >> >> > [2]
>>> >> >> >> http://www.apache.org/foundation/voting.html#ReleaseVotes
>>> >> >> >> > [3]
http://people.apache.org/~lu4242/myfaces201binsrc
<http://people.apache.org/%7Elu4242/myfaces201binsrc>
>>> >> >> >> <http://people.apache.org/%7Elu4242/myfaces201binsrc>
>>> >> >> >> >
>>> >> >> >> > [4]
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12315117
<http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12315117>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
>>> >> >> >>
<http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12315117
<http://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=10600&styleName=Html&version=12315117>>
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >> >
>>> >> >> >>
>>> >> >> >>
>>> >> >> >
>>> >> >> >
>>> >> >> >
>>> >> >
>>> >> >
>>> >
>>> >
>>
>
>
