Hi,
For this issue,  TRINIDAD-2026 memory leak in skinstyleprovider, I use  a least-recently-used-map instead of a HashMap so I can limit the number of skins that I cache.
This is useful if an application is built so that they have many skins, like if they have a skin per user, so that the numbe of cached skins doesn't keep growing and growing.
I default to size 20, but this is also configurable via a web.xml context-parameter.

Here are some proposed names:
org.apache.myfaces.trinidad.skin.NUMBER_OF_SKINS_CACHE_SIZE
org.apache.myfaces.trinidad.skin.SKIN_STYLE_PROVIDER_CACHE_SIZE
org.apache.myfaces.trinidad.skin.SKIN_STYLE_PROVIDER_LRU_CACHE_SIZE

in the patch it is org.apache.myfaces.trinidad.skin.SKIN_STYLE_PROVIDER_CACHE_SIZE, so if I don't hear any objections, this is what I will use.

Thanks,
Jeanne

Reply via email to