On Sun, Sep 11, 2016 at 08:19:58PM +0100, Tim Hutt wrote:
> I like C++ and would like to use it with MyNewt, so I've written a very
> hacky tool in Go to detect C++ header guards:
> 
> https://github.com/Timmmm/GuardChecker
> 
> Here is the result of running it on apache-mynewt-core:
> 
> https://github.com/Timmmm/incubator-mynewt-core/commit/fec88d1c8b3f36e14eef700ab37b18ef78cd2418
> 
> It's not perfect but it seems to work ok. Check the commit message and the
> GuardChecker Readme for some more details.
> 
> What do you think?

Look great to me, thanks!  I just have a question - the commit message
indicates that two files were not modified:

    libs/baselibc/src/baselibc_test/unittests.h
    libs/shell/include/shell/shell_prompt.h

Why did you exclude these files?

Thanks,
Chris

Reply via email to