jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the legacy Task URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192001641
########## File path: runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java ########## @@ -246,64 +245,49 @@ private void addInputFromThisStage(final Task task, final TaskDataHandler dataHa } /** - * Add output outputCollectors to each {@link Task}. - * Output outputCollector denotes the one and only one outputCollector of this task. - * Check the outgoing edges that will use this outputCollector, - * and set this outputCollector as side input if any one of the edges uses this outputCollector as side input. - * - * @param task the Task to add output outputCollectors to. + * Add output outputCollectors to each {@link IRVertex}. + * @param irVertex the IRVertex to add output outputCollectors to. Review comment: output outputCollectors -> outputCollectors? `output outputCollectors` in the original comment seem strange by themselves 😄 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services