jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the
legacy Task
URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192003647
##########
File path:
runtime/master/src/main/java/edu/snu/nemo/runtime/master/scheduler/BatchSingleJobScheduler.java
##########
@@ -392,31 +393,35 @@ private void scheduleStage(final PhysicalStage
stageToSchedule) {
LOG.info("Scheduling Stage {}", stageToSchedule.getId());
// each readable and source task will be bounded in executor.
- final List<Map<String, Readable>> logicalTaskIdToReadables =
stageToSchedule.getLogicalTaskIdToReadables();
+ final List<Map<String, Readable>> vertexIdToReadables =
stageToSchedule.getVertexIdToReadables();
taskIdsToSchedule.forEach(taskId -> {
blockManagerMaster.onProducerTaskScheduled(taskId);
final int taskIdx = RuntimeIdGenerator.getIndexFromTaskId(taskId);
final int attemptIdx =
jobStateManager.getCurrentAttemptIndexForTask(taskId);
LOG.debug("Enqueueing {}", taskId);
- pendingTaskCollection.add(new ScheduledTask(physicalPlan.getId(),
- stageToSchedule.getSerializedTaskDag(), taskId, stageIncomingEdges,
stageOutgoingEdges, attemptIdx,
- stageToSchedule.getContainerType(),
logicalTaskIdToReadables.get(taskIdx)));
+ pendingTaskCollection.add(new ExecutableTask(
+ physicalPlan.getId(),
+ taskId,
+ attemptIdx,
+ stageToSchedule.getContainerType(),
+ stageToSchedule.getSerializedIRDAG(),
+ stageIncomingEdges,
+ stageOutgoingEdges,
+ vertexIdToReadables.get(taskIdx)));
});
schedulerRunner.onATaskAvailable();
}
/**
- * Gets the DAG of a task from it's ID.
- *
- * @param taskId the ID of the task to get.
- * @return the DAG of the task.
+ * @param taskId id of the task
+ * @return the dag
Review comment:
the IR DAG?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
