jeongyooneo commented on a change in pull request #24: [NEMO-79] Clean up the
legacy Task
URL: https://github.com/apache/incubator-nemo/pull/24#discussion_r192001967
##########
File path:
runtime/executor/src/main/java/edu/snu/nemo/runtime/executor/TaskExecutor.java
##########
@@ -374,22 +362,21 @@ private void prepareInputFromOtherStages() {
}
/**
- * Check whether all tasks in this Task are finished.
+ * Check whether all vertices in this Task are finished.
*
- * @return true if all tasks are finished.
+ * @return true if all vertices are finished.
*/
- private boolean finishedAllTasks() {
+ private boolean finishedAllVertices() {
// Total number of Tasks
- int taskNum = taskDataHandlers.size();
- int finishedTaskNum = finishedTaskIds.size();
-
+ int taskNum = irVertexDataHandlers.size();
+ int finishedTaskNum = finishedVertexIds.size();
Review comment:
finishedVertexNum?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
