taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234427669
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/AbstractDoFnTransform.java
##########
@@ -47,12 +48,12 @@
* @param <OutputT> output type.
*/
public abstract class AbstractDoFnTransform<InputT, InterT, OutputT> implements
- Transform<WindowedValue<InputT>, WindowedValue<OutputT>> {
+ Transform<InputT, WindowedValue<OutputT>> {
private static final Logger LOG =
LoggerFactory.getLogger(AbstractDoFnTransform.class.getName());
private final TupleTag<OutputT> mainOutputTag;
private final List<TupleTag<?>> additionalOutputTags;
- private final Collection<PCollectionView<?>> sideInputs;
+ private final Map<Integer, PCollectionView<?>> sideInputs;
Review comment:
We don't need this map if we use `view` instead of `index`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
