taegeonum commented on a change in pull request #159: [NEMO-216,251,259]
Support side inputs and windowing
URL: https://github.com/apache/incubator-nemo/pull/159#discussion_r234427699
##########
File path:
compiler/frontend/beam/src/main/java/org/apache/nemo/compiler/frontend/beam/transform/AbstractDoFnTransform.java
##########
@@ -205,6 +212,11 @@ public TimerInternals timerInternals() {
inputCoder,
outputCoders,
windowingStrategy);
+
+ pushBackRunner = SimplePushbackSideInputDoFnRunner.<InterT, OutputT>create(
Review comment:
It would be good to use this runner only if the `DoFn` handles side inputs.
If the side input is empty, using doFnRunner would be good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
