On Sun, 27 Feb 2022 at 15:06, Eric Bresie <ebre...@gmail.com> wrote: > Maybe a late comment and lessons learned but looking at the list of items > there seems to be a significant lack of issue (JIRA or github) issue > references in PR titles. I always assume the general rule was to include > the related ticket to help in eventually closing it out in the applicable > issue tracking system.
No, that kind of was already a lesson learned, see https://github.com/apache/netbeans/milestone/14?closed=1 We have moved to (or really just acknowledged!) that pull requests are the primary change record. Issues are user facing, and are explicitly not required for a pull request that's ready to submit, by committers or contributors. The issue doesn't need to be in the title - it's not only confusing in that PRs and issues use the same ID source, but it also doesn't work to link things up correctly. If an issue exists it should be mentioned in the PR description or explicitly linked. Try clicking through to some of the PRs from 13 RC phase. > Will any referenced issue tickets get fully closed out as part of the > release process or is that up to the developer? I kind of see it pending > inclusion in an actual release before closing it out (although granted with > Github issues, the PR gets closed as part of this so maybe that a plus for > the github issue usage) For GitHub issues we should hopefully see automatic closing on merge to master. Unfortunately, it seems like automatic closing on merge to delivery doesn't work, including when merged through to master, so that's an additional little job for the release team. They have hopefully all been done for 13 though. JIRA ticket closing - who knows! :-) Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
