On Sat, 20 Aug 2022 at 07:37, Jaroslav Tulach <jaroslav.tul...@gmail.com> wrote: > Executive summary: If a "cleanup PR" has to touch `.sig` files, then it is not > a cleanup!
Totally agree! However, the interesting thing here is that if it wasn't for the bitshift value changes showing up in https://github.com/apache/netbeans/pull/4487 this might not have been picked up. Shouldn't the constant value changes have also caused test failures in the original cleanup PR? Maybe in Michael's CI changes we could also look at failing PRs that touch .sig files unless they have a particular label set on them (eg. API change)? Best wishes, Neil --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@netbeans.apache.org For additional commands, e-mail: dev-h...@netbeans.apache.org For further information about the NetBeans mailing lists, visit: https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
