On Wed, 18 Jan 2023, 18:42 Ernie Rael, <[email protected]> wrote: > On 23/01/18 9:59 AM, Neil C Smith wrote: > > Looking at https://github.com/apache/netbeans/pull/5280 it had > > approval from one of the four people requested to review. > > This is somewhat of a grey area to me. I often see PRs merged where > some reviewers don't weigh in. In any event, the PR should have been > opened earlier in the cycle. >
Agree on both points - grey area, and earlier might have been easier. > > Looks like > > some of the conversation still ongoing? > There's conversation about a different long outstanding issue that isn't > about this PR; it has to do with dialog placement. After the recent > discussion, I might know where the problem is (I can't reproduce it) but > need some input from someone who sees the problem. Something for > nb-18. > Ah, OK. Only just glanced through. > I've only just looked at it, > > but might have a request for change. > Cool. That livens things up and makes it more interesting. > Good thing nobody merged it. > Changed it to just a comment. I'm not sure how many people really use the affected code without the window system. > > > If rebased on delivery and review completed it's a possible bug fix > > for rc2, > Let see what happens... Rebasing is no problem, that's a convenience about > making changes in an area that's rarely touched. > Should just be changing the base in the PR UI as it was already open at freeze. > but I'm not making that call. > > (as a commenter/reviewer, seems you're putting on a different hat ;-) ) > Yes, release team hat is on! It's easier when we're not making that call as well where possible. So, yes, be good if one of the other reviewers commented on whether it should go in rc2 or not. Just saying that is an option for someone to move back to the NB17 milestone. Best wishes, Neil
