On Tue, Oct 3, 2017 at 11:51 AM, Antonio <anto...@vieiro.net> wrote:
> On 03/10/17 11:09, Jaroslav Tulach wrote:
>
>> Hello Antonio,
>> thanks for your help.
>>
>
> My pleasure.
>
> I'm seeing nbproject/build-impl.xml, nbproject/jfx-impl.xml and
>>> nbproject/genfiles.properties.
>>>
>>> These are automatically generated in the IDE so,
>>>
>>> - Should I remove them from git?
>>>
>>
>> No, add them to the rat tool exclude list.
>>
>
> Done.
>
> I've added '**/nbproject/*-impl.xml' and '**/nbproject/genfiles.properties'
> to the rat exclusion list. (Note: **/nbproject/, so that affects qa-test
> projects as well, and not */nbproject that only affects the module).
>
I personally would probably be more strict and and exclude specifically
**/nbproject/build-impl.xml and **/nbproject/jfx-impl.xml. Would it be
possible to grep the excluded files for word "CDDL", to be sure there's no
forgotten license header in them? Using ** seems OK to me.
>
> Shall I submit a pull request with these?
>
Yes please. Thanks for your help,
Jan
>
>
>> Problems to be solved centrally
>>> build.xml, build-impl.xml, project.properties, genfiles.properties,
>>>
>>
>> I would suggest to add licenses to build.xml and project.properties - e.g.
>> those that aren't generated.
>>
>
> Of course.
>
