Milan, No worries - honored that you chose NiFi to be the first project that you contributed to!
When one of the NiFi committers has reviewed the PR and is happy with it, he/she will merge the PR to master and will close your JIRA. You won't need to do anything, unless the reviewer leaves feedback that something needs to be addressed. Thanks! -Mark On Sep 22, 2017, at 12:41 PM, Milan Chandna <milan.chan...@microsoft.com.INVALID<mailto:milan.chan...@microsoft.com.INVALID>> wrote: OK, thanks for updating. But how will I know if my PR is ready to be merged in master so that I can close JIRA? Sorry for silly questions but this is my first contribution in open source, kindly bear. Regards, Milan. -----Original Message----- From: Jeff [mailto:jtsw...@gmail.com] Sent: Friday, September 22, 2017 9:58 PM To: dev@nifi.apache.org<mailto:dev@nifi.apache.org> Subject: [DISCUSS} Closing in on a NiFi 1.4.0 release? Just an update on the RC for 1.4.0. I will be starting the release process between 1530 and 1600 EST today. That's approximately 3 hours from now. On Thu, Sep 21, 2017 at 5:30 PM Jeff <jtsw...@gmail.com<mailto:jtsw...@gmail.com>> wrote: FYI, I'll be starting the release candidate prep around noon EST on the 22nd, which is less than 24 hours from now. At that point, I'll be moving tickets out of 1.4.0. On Thu, Sep 21, 2017, 3:52 PM Milan Chandna <milan.chan...@microsoft.com.invalid<mailto:milan.chan...@microsoft.com.invalid>> wrote: Thanks Mark (and Jeff) for clearing this out. Yes I would like below mentioned Jira (supporting ADLS) and PR to be reviewed asap, so that we can get it in 1.4.0. Jira: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissu es.apache.org<http://es.apache.org/>%2Fjira%2Fbrowse%2FNIFI-4360&data=02%7C01%7CMilan.Chandn a%40microsoft.com<http://40microsoft.com/>%7C24035c0efa204e4b2f9008d501d6ff39%7C72f988bf86f141 af91ab2d7cd011db47%7C1%7C0%7C636416945281758772&sdata=lNbSA5mMpvct6fV BycMzLZJBt08OeyUazjnTh8drRDA%3D&reserved=0 PR: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith ub.com<http://ub.com/>%2Fapache%2Fnifi%2Fpull%2F2158&data=02%7C01%7CMilan.Chandna%40m icrosoft.com<http://icrosoft.com/>%7C24035c0efa204e4b2f9008d501d6ff39%7C72f988bf86f141af91a b2d7cd011db47%7C1%7C0%7C636416945281758772&sdata=VGGVB%2BGP44vaevmQXa T55Y5pSPhbZxZyN7UeIVyA4pU%3D&reserved=0 Though the commits are very stable, but would be great to get this reviewed by NIFI experts. Really want to see ADLS shining out in NIFI along with its co-offerings like HDFS. P.S: These processors are similar to HDFS (in implementation), if that helps for reviewers to take it up. Regards, -Milan. -----Original Message----- From: Mark Payne [mailto:marka...@hotmail.com] Sent: Thursday, September 21, 2017 6:16 PM To: dev@nifi.apache.org<mailto:dev@nifi.apache.org> Subject: Re: [EXT] Re: [DISCUSS} Closing in on a NiFi 1.4.0 release? Milan, There is no specific deadline. The PR would just need to be merged to master by the time that the branch is created for the Release Candidate. I don't know exactly when that is going to happen, since I am not the Release Manager for this particular release. However, I do expect it to be quite soon. If you are able to submit a PR that you'd like to have considered for inclusion in the release, you can submit it and let us know so that someone will review it if time permits. That said, if there are issues that need to be addressed before merging the PR, I don't think we would hold up the release to get it in unless it is considered a "BLOCKER" jira. Does that help? Thanks -Mark On Sep 21, 2017, at 4:18 AM, Milan Chandna <milan.chan...@microsoft.com.INVALID<mailto:milan.chan...@microsoft.com.INVALID>> wrote: Do we have a deadline to get the issue resolved, to include it in 1.4.0 release. -----Original Message----- From: Adam Taft [mailto:a...@adamtaft.com] Sent: Thursday, September 21, 2017 9:20 AM To: dev@nifi.apache.org<mailto:dev@nifi.apache.org> Subject: Re: [EXT] Re: [DISCUSS} Closing in on a NiFi 1.4.0 release? Here's another good link to try, maybe a little easier to read: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fis sue s.apache.org%2Fjira%2Fprojects%2FNIFI%2Fversions%2F12340589&data=02 %7C 01%7CMilan.Chandna%40microsoft.com%7C21581ed9a39548be836e08d500a3e9 00% 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636415626344144936&sda ta= kO%2ByQJA%2FchMrvYYMpUZ%2FGOj%2FYVNEWgbmtahAr6ITrVk%3D&reserved=0 On Wed, Sep 20, 2017 at 8:01 AM, Brandon DeVries <b...@jhu.edu> wrote: Mayank, Try this: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fi ssu e s.apache.org%2Fjira%2Fissues%2F%3Fjql%3Dproject%2520%25&data=02%7C 01% 7 CMilan.Chandna%40microsoft.com%7C21581ed9a39548be836e08d500a3e900% 7C7 2 f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636415626344144936&sdata= U5d I A%2FD0S3yLy4trFBag8IZ3mVJtCD1tWtdLc2hZ2rQ%3D&reserved=0 3D%20NIFI%20AND%20fixVersion%20%3D%201.4.0%20ORDER%20BY%20status%2 0DE S C Brandon On Wed, Sep 20, 2017 at 9:57 AM mayank rathi <mayank.ra...@gmail.com> wrote: Hello All, How can we find out list of fixes that will go in 1.4.0 release? Thanks!! On Wed, Sep 20, 2017 at 9:53 AM, Brandon DeVries <b...@jhu.edu> wrote: All, I think we should plan on calling for a vote on Friday. That gives two days to wrap up any outstanding tickets that anyone feels really belong in 1.4. At that point the remaining tickets can be shifted to a future release. If there are tickets that are not getting the attention they need to make it into the release, let the list know. Any objections? Brandon On Wed, Sep 20, 2017 at 12:32 AM Koji Kawamura <ijokaruma...@gmail.com wrote: Hi Paul, I was able to reproduce the GenerateTableFetch processor issue reported by NIFI-4395. Please go ahead and provide a PR, I can review it. Thanks, Koji On Wed, Sep 20, 2017 at 1:10 PM, Paul Gibeault (pagibeault) <pagibea...@micron.com> wrote: We have submitted this JIRA ticket: https://na01.safelinks.protection.outlook.com/?url=https%3A%2F %2Fissues.apache.org%2Fjira%2Fbrowse%2FNIFI-4395&data=02%7C01% 7CMilan.Chandna%40microsoft.com%7C21581ed9a39548be836e08d500a3 e900%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636415626344 144936&sdata=cSKg20gPxzXXabttEoU4poDyu8k%2BkE2bFybrIc3NKSI%3D& reserved=0 This issue causes GenerateTableFetch processor to malfunction after a server restart. We are very interested in getting this released in 1.4.0 and are willing to provide the PR if there is still time. Thanks, Paul Gibeault -----Original Message----- From: Michael Hogue [mailto:michael.p.hogu...@gmail.com] Sent: Tuesday, September 19, 2017 9:36 AM To: dev@nifi.apache.org Subject: [EXT] Re: [DISCUSS} Closing in on a NiFi 1.4.0 release? All, There are a couple of issues with open PRs that i think would be desirable to get into 1.4.0: - https://na01.safelinks.protection.outlook.com/?url=https%3A%2F %2Fgithub.com%2Fapache%2Fnifi%2Fpull%2F2163&data=02%7C01%7CMil an.Chandna%40microsoft.com%7C21581ed9a39548be836e08d500a3e900% 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63641562634414493 6&sdata=TOF8FHbjissTDtdx33E7xUb4JrHc7R5BV6SUNfTtn%2Fc%3D&reser ved=0 - trivial one-liner in ListenGRPC - https://na01.safelinks.protection.outlook.com/?url=https%3A%2F %2Fgithub.com%2Fapache%2Fnifi%2Fpull%2F1985&data=02%7C01%7CMil an.Chandna%40microsoft.com%7C21581ed9a39548be836e08d500a3e900% 7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C63641562634414493 6&sdata=B3hDDiR3W6jcaas7JyoBOr96pVdtnIyeWSWXAF2MvhQ%3D&reserve d=0 - support TLS algorithm selection via SSLContextService in HandleHTTPRequest Thanks, Mike On Tue, Sep 19, 2017 at 10:46 AM Mark Bean <mark.o.b...@gmail.com> wrote: I agree with including only those which can be completed quickly in 1.4.0. We are anxious for the next release to begin exercising some of the new features. IMO it's time to get 1.4.0 out the door. Thanks, Mark On Mon, Sep 18, 2017 at 6:59 PM, Jeff <jtsw...@gmail.com> wrote: Still good. Was looking through tickets yesterday and today and while review progress has been made on some PRs, it might be best to move JIRAs tagged for 1.4.0 that have PRs and aren't on the cusp of being committed to post 1.4.0. Thoughts? On Mon, Sep 18, 2017 at 2:50 PM Joe Witt <joe.w...@gmail.com> wrote: Definitely agree with Brandon that due for a 1.4.0 and it has some really nice things in it.... Jeff Storck volunteered to RM. Jeff you still good? Anything I can help with? Thanks Joe On Mon, Sep 18, 2017 at 2:28 PM, Brandon DeVries <b...@jhu.edu wrote: There are significant changes in 1.4.0 that I am actively waiting on... On Mon, Sep 18, 2017 at 2:25 PM Russell Bateman < r...@windofkeltia.com wrote: I don't know. Are we due for a release? Is time-since the significant factor in a release cycle or is growing features part of it? 1.3.0 subsists with no bump of the third digit. This is an oddly stable .0 product (though the third digit had somewhat different semantics in NiFi 0.x). No bug fixes to 1.3.0 in its roughly 6-month history? That's an achievement. If there have been important features worked on and ready to go, by all means, let's have 1.4.0. But if 1.4.0 is little more than 1.3.1, let's rethink why we'd do that. Russ On 09/18/2017 12:08 PM, Brandon DeVries wrote: +1, it seems like we're do for a release. It's been +a week, +and a couple of the mentioned tickets have shown progress... but a number haven't. If no one wants to get them wrapped up, can we put them off to 1.5? On Mon, Sep 11, 2017 at 11:39 AM Wes Lawrence < wesleyll...@gmail.com> wrote: I'd also like NIFI-4242 and NIFI-4181 added (or if it's OK, I can label their fix versions for 1.4.0. I wasn't sure sure I could do that, or if that should be left to PMC/Commiters) NIFI-4242 < https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiss ues.apache.org%2Fjira%2Fbrowse%2FNIFI-4242&data=02%7C01%7CMilan.Chan dna%40microsoft.com%7C21581ed9a39548be836e08d500a3e900%7C72f988bf86f 141af91ab2d7cd011db47%7C1%7C0%7C636415626344144936&sdata=2GWZOSraWFw BNojmq2DNywvLrZ90x1k1%2BMowqdMKIwU%3D&reserved=0> has a patch with feedback, and I'll be pushing a new patch addressing the feedback later today. NIFI-4181 < https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fiss ues.apache.org%2Fjira%2Fbrowse%2FNIFI-4181&data=02%7C01%7CMilan.Chan dna%40microsoft.com%7C21581ed9a39548be836e08d500a3e900%7C72f988bf86f 141af91ab2d7cd011db47%7C1%7C0%7C636415626344144936&sdata=XbuimqOK0YE lhgoy07WBnsGug3apoSNqTMavqdL10Jg%3D&reserved=0> has a patch with feedback, and I'd like to address the feedback for 1.4.0 if possible. --Wes On Mon, Sep 11, 2017 at 10:33 AM, Christopher Currie < christop...@currie.com wrote: In addition to this list, I'd like to request that https://na01.safelinks.protection.outlook.com/?url =https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2 FNIFI-3950&data=02%7C01%7CMilan.Chandna%40microsof t.com%7C21581ed9a39548be836e08d500a3e900%7C72f988b f86f141af91ab2d7cd011db47%7C1%7C0%7C63641562634414 4936&sdata=03rih6%2FMIhmWROuekZqkzkoD%2FjGiDba26Jl O5qOE0Vc%3D&reserved=0 also be added. I created a PR for it, and I'm happy to work with a committer to clean it up for project standards if needed. Christopher On Mon, Sep 11, 2017 at 6:44 AM James Wing <jvw...@gmail.com> wrote: +1 It does seem to be about time to get a +release out, +and we should certainly take advantage of your offer to performing RM duties. Thank you for that. On Sun, Sep 10, 2017 at 5:45 PM, Jeff < jtsw...@gmail.com> wrote: All, On the dev and users lists there have been some questions about when the next release of NiFi would be. I would like perform RM duties, and get things started on identifying what the community would like to include in the release of NiFi 1.4.0 that has not already been reviewed and committed to master. There are 11 unresolved JIRAs tagged with a fix version of 1.4.0. https://na01.safelinks.protection.outlook.com/?u rl=https%3A%2F%2Fissues.apache.org%2F&data=02%7C 01%7CMilan.Chandna%40microsoft.com%7C21581ed9a39 548be836e08d500a3e900%7C72f988bf86f141af91ab2d7c d011db47%7C1%7C0%7C636415626344144936&sdata=9u3x YMcS9uMiM8SJPWvxNu2ekLT365BSlo0qfh%2FsBio%3D&res erved=0 jira/issues/?jql=project%20% 3D%20NIFI%20AND%20resolution% 20%3D%20Unresolved%20AND% 20fixVersion%20%3D%201.4.0%20ORDER%20BY%20priori ty% 20DESC%2C%20key%20DESC Are there any reasons to hold off on a 1.4.0 release? Are there particular JIRAs that the community considers necessary to have as part of the release? Let's discuss! Thanks, Jeff -- NOTICE: This email message is for the sole use of the intended recipient(s) and may contain confidential and privileged information. Any unauthorized review, use, disclosure or distribution is prohibited. If you are not the intended recipient, please contact the sender by reply email and destroy all copies of the original message.
