Ah, thanks for clarifying. I am also not aware of such functionality on GitHub. For me, the most valuable feature is being able to better curate our old/stale issues without empty commits and, if so desired, obviate the need for the "This closes" phrasing.
In terms of my personal review processes, I don't see myself carrying out many merges from the web itself given that I am typically on the command line anyway doing builds and testing. Not really an answer to your original question but I hope this better illustrates the integration capabilities. --aldrin On Fri, Dec 14, 2018 at 5:10 PM Peter Wicks (pwicks) <pwi...@micron.com> wrote: > Aldrin, > > Your comments have left me confused. Yes, in the past, I would always `-s` > to sign the commits and push them. But isn't the idea behind the improved > GitHub integration is that now I can just go to the PR and tell GitHub to > accept the PR after I've reviewed it. Thus the manual act of amending the > commit and signing it does not happen. Does that mean there is no Sign Off > happening to the commit? > > --Peter > > -----Original Message----- > From: Aldrin Piri [mailto:aldrinp...@gmail.com] > Sent: Friday, December 14, 2018 2:32 PM > To: dev <dev@nifi.apache.org> > Subject: Re: [EXT] Re: [DISCUSS] Early, voluntary relocation to GitBox > > That level of interoperability is not there and, from some quick > searching, do not believe it to be something that is supported. [1] > > Not sure what is meant by sign-off being automated. Personally, I use the > -s flag when amending/pushing reviewed commits. > > [1] > > https://blogs.apache.org/infra/entry/improved_integration_between_apache_and > > On Fri, Dec 14, 2018 at 3:34 PM Peter Wicks (pwicks) <pwi...@micron.com> > wrote: > > > Does closing a PR through GitHub close the JIRA ticket correctly? I'm > > assuming sign-off is automated this way, but wasn't sure about this step. > > > > Thanks, > > Peter > > > > -----Original Message----- > > From: Aldrin Piri [mailto:aldrinp...@gmail.com] > > Sent: Friday, December 14, 2018 6:23 AM > > To: dev <dev@nifi.apache.org> > > Subject: [EXT] Re: [DISCUSS] Early, voluntary relocation to GitBox > > > > Some clarifying notes until I can get all the updates into place and > > generate a new email. > > > > There are now two locations that are writable by committers for each > > of our repositories. The updated repository locations can be seen in > > the Apache NiFi section of https://gitbox.apache.org/repos/asf. NiFi, > > for instance, is available at > > https://gitbox.apache.org/repos/asf/nifi-site.git. The web view of > > the repository is located at > > https://gitbox.apache.org/repos/asf?p=nifi-site.git. Please note the > > subtle distinction! > > > > If you are a contributor still on their way to committership or you > > are committer content with the same functionality we had with our old > > setup (git-wip), you will use the above listed locations. You can > > update your location by performing the following steps: > > > > - Go to the root of your source directory, we'll use nifi as an > example > > - cd ${repo_home}/nifi > > - Update your remote. On a default checkout this will be origin, but > > use the name that is pointing to the old git-wip location (you can > view > > these using git remote -v) > > - git remote set-url origin > > https://gitbox.apache.org/repos/asf/nifi.git > > > > > > If you are a committer and interested in making use of the tighter > > GitHub integration, there are a few steps needed to enable this > > described at https://gitbox.apache.org/setup/. Please follow those > > and give some time to allow the background processes sync. > > Successfully completing them should result in the email from GitHub on > > behalf of Gitbox I mentioned previously. > > > > Again, look for a bit more polished set of instructions in the next > > hour or so but feel free to add any questions here in the interim if > > it is holding you up. > > > > > > > > On Fri, Dec 14, 2018 at 7:35 AM Aldrin Piri <aldrinp...@gmail.com> > wrote: > > > > > Hey all, > > > > > > Just a quick note that migration has completed. I'll be gathering > > > up information shortly and sending out another, separate email to > > > the community with any needed changes and will work to update our > > > docs appropriately. > > > > > > Committers, you should have received an email regarding you addition > > > to the nifi group on GitHub. > > > > > > --aldrin > > > > > > On Thu, Dec 13, 2018 at 1:20 PM Aldrin Piri <aldrinp...@gmail.com> > > wrote: > > > > > >> Hey folks, > > >> > > >> The JIRA ticket has been submitted [1]. I will keep this thread > > >> updated as things progress and then generate a separate "helper" > > >> email for instructions/any updates that may be needed upon completion. > > >> > > >> [1] https://issues.apache.org/jira/browse/INFRA-17419 > > >> > > >> On Mon, Dec 10, 2018 at 10:51 AM Pierre Villard < > > >> pierre.villard...@gmail.com> wrote: > > >> > > >>> +1 as well, should ease the contribution workflow. > > >>> Thanks for volunteering Aldrin. > > >>> > > >>> Le lun. 10 déc. 2018 à 16:41, Laszlo Horvath > > >>> <lhorv...@hortonworks.com> a écrit : > > >>> > > >>> > +1 > > >>> > > > >>> > On 10/12/2018, 15:22, "Michael Moser" <moser...@gmail.com> wrote: > > >>> > > > >>> > +1 from me, sounds great. > > >>> > > > >>> > > > >>> > On Mon, Dec 10, 2018 at 4:07 AM Arpad Boda > > >>> > <ab...@hortonworks.com> > > >>> > wrote: > > >>> > > > >>> > > +1 (for being the guinea pig __ ) > > >>> > > > > >>> > > On 09/12/2018, 04:01, "Aldrin Piri" <aldrinp...@gmail.com> > > >>> wrote: > > >>> > > > > >>> > > Thanks to those of you that responded. > > >>> > > > > >>> > > I think my tentative plan is to give this a few more days > > to > > >>> see > > >>> > if > > >>> > > there > > >>> > > are any strong objections. Otherwise, I'll look to file > > the > > >>> > ticket > > >>> > > around > > >>> > > midweek and then look to begin the process toward the end > > of > > >>> > next week > > >>> > > to > > >>> > > hopefully minimize disruptions. Thanks again! > > >>> > > > > >>> > > On Sat, Dec 8, 2018 at 12:09 PM Tony Kurc < > > trk...@gmail.com> > > >>> > wrote: > > >>> > > > > >>> > > > +1, sounds like a great idea > > >>> > > > > > >>> > > > On Sat, Dec 8, 2018 at 7:44 AM Mike Thomsen < > > >>> > mikerthom...@gmail.com> > > >>> > > > wrote: > > >>> > > > > > >>> > > > > +1 > > >>> > > > > > > >>> > > > > On Fri, Dec 7, 2018 at 9:08 PM Sivaprasanna < > > >>> > > sivaprasanna...@gmail.com> > > >>> > > > > wrote: > > >>> > > > > > > >>> > > > > > +1 (non-binding) > > >>> > > > > > > > >>> > > > > > I’m in. Thanks for doing it, Aldrin. > > >>> > > > > > > > >>> > > > > > > > >>> > > > > > On Sat, 8 Dec 2018 at 7:32 AM, James Wing < > > >>> > jvw...@gmail.com> > > >>> > > wrote: > > >>> > > > > > > > >>> > > > > > > +1, thanks for volunteering. > > >>> > > > > > > > > >>> > > > > > > > On Dec 7, 2018, at 13:39, Kevin Doran < > > >>> > > kdoran.apa...@gmail.com> > > >>> > > > > wrote: > > >>> > > > > > > > > > >>> > > > > > > > +1 > > >>> > > > > > > > > > >>> > > > > > > > On 12/7/18, 15:17, "Andy LoPresto" < > > >>> > alopre...@apache.org> > > >>> > > wrote: > > >>> > > > > > > > > > >>> > > > > > > > +1. > > >>> > > > > > > > > > >>> > > > > > > > Andy LoPresto > > >>> > > > > > > > alopre...@apache.org > > >>> > > > > > > > alopresto.apa...@gmail.com > > >>> > > > > > > > PGP Fingerprint: 70EC B3E5 98A6 5A3F D3C4 > > BACE > > >>> > 3C6E F65B > > >>> > > 2F7D > > >>> > > > > EF69 > > >>> > > > > > > > > > >>> > > > > > > >> On Dec 7, 2018, at 11:11 AM, Aldrin Piri < > > >>> > > aldrinp...@gmail.com> > > >>> > > > > > wrote: > > >>> > > > > > > >> > > >>> > > > > > > >> Hey folks, > > >>> > > > > > > >> > > >>> > > > > > > >> Daniel Gruno sent an email to the dev list > about > > >>> the > > >>> > > deprecation > > >>> > > > of > > >>> > > > > > our > > >>> > > > > > > >> git-wip repositories [1] (these are the > > canonical > > >>> > repos that > > >>> > > > > > committers > > >>> > > > > > > >> push changes to and are currently mirrored to > > >>> GitHub) > > >>> > and > > >>> > > > > > transitioning > > >>> > > > > > > to > > >>> > > > > > > >> GitBox [2]. > > >>> > > > > > > >> > > >>> > > > > > > >> As highlighted in that email, this will not be > > an > > >>> > optional > > >>> > > change, > > >>> > > > > > only > > >>> > > > > > > in > > >>> > > > > > > >> when and how it happens. There was a previous > > >>> > discussion > > >>> > > over > > >>> > > > this > > >>> > > > > > > topic > > >>> > > > > > > >> [3] where it was generally well received but I > > >>> think > > >>> > some > > >>> > > of the > > >>> > > > > > > logistics > > >>> > > > > > > >> were never mapped out and thus the actual > > request > > >>> to > > >>> > do so > > >>> > > was > > >>> > > > never > > >>> > > > > > > >> executed. > > >>> > > > > > > >> > > >>> > > > > > > >> I am proposing we volunteer for the early > > >>> > relocation. The > > >>> > > process > > >>> > > > > > > looks to > > >>> > > > > > > >> be fairly straightforward and should > ultimately > > >>> only > > >>> > result > > >>> > > in > > >>> > > > > > requiring > > >>> > > > > > > >> our contributors to add/replace their original > > >>> > git-wip based > > >>> > > > > remotes. > > >>> > > > > > > >> > > >>> > > > > > > >> If folks are in favor, I am happy to file the > > >>> > requisite > > >>> > > INFRA > > >>> > > > ticket > > >>> > > > > > and > > >>> > > > > > > >> provide the associated communication/docs to > the > > >>> > community > > >>> > > to make > > >>> > > > > > this > > >>> > > > > > > >> happen. Again, this is only about making the > > >>> choice > > >>> > to > > >>> > > perform > > >>> > > > this > > >>> > > > > > > >> migration now, in a coordinated manner, in > lieu > > of > > >>> > the mass > > >>> > > > > migration > > >>> > > > > > > that > > >>> > > > > > > >> would happen later. > > >>> > > > > > > >> > > >>> > > > > > > >> From a project management standpoint, I think > it > > >>> is a > > >>> > nice > > >>> > > bit of > > >>> > > > > > > >> functionality that lets us better curate our > > open > > >>> PRs > > >>> > and, > > >>> > > given > > >>> > > > my > > >>> > > > > > > prior > > >>> > > > > > > >> interest in the subject, would like to see it > > >>> happen. > > >>> > > > > > > >> > > >>> > > > > > > >> --aldrin > > >>> > > > > > > >> > > >>> > > > > > > >> [1] > > >>> > > > > > > >> > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> https://lists.apache.org/thread.html/8247bb17671d6131b1d7a646b4c01 > > >>> 8b 21aac390c4f627d8fb1f421b2@%3Cdev.nifi.apache.org%3E > > >>> > > > > > > >> [2] https://gitbox.apache.org/ > > >>> > > > > > > >> [3] > > >>> > > > > > > >> > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > >>> https://lists.apache.org/thread.html/de5e103994f356b1b8a572410938e > > >>> ef 44af8cb352210e35305c04bc9@%3Cdev.nifi.apache.org%3E > > >>> > > > > > > > > > >>> > > > > > > > > > >>> > > > > > > > > >>> > > > > > > > >>> > > > > > > >>> > > > > > >>> > > > > >>> > > > > >>> > > > > >>> > > > >>> > > > >>> > > > >>> > > >> > > >
