Hi Greg, Yes, it may be horrible. Please don't look at the results right now then... this is a work in progress.
I'm just trying to do the development and coordination in the open, as the Apache folks have asked— no off-list communication, right? I just posted these so David and others could easily look at the output, not because I was going to submit any kind of PR. It seems like it should be ok to show work-in-progress here. Otherwise how can we collaborate? When it's more fully baked, we'll let you know. :) -adam On Mon, Mar 16, 2020 at 4:36 PM Gregory Nutt <spudan...@gmail.com> wrote: > I mentioned in the previous email that the tools was screwing up > vertifcal alignment is places where it is recommend and in places where > is it required. Here is an example of the later: > > * sched/irq/irq.h > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-08538ebd3dc53f5f85f131c24c84be9d > >, > beginning at line 75 all veritical alignment of right hand comments > lost. > > A few more: > > * clock_timespec_subtract.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-906c272ac7c0b95506056c0c431ab276 > >, > insanity at line 69. Similar nonsense at group_setuid.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-f39b80ac9e4440e2d2889ef55425f3ef > > > line 76, group_signal.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-750c9acf01eefd4c69e3186ceb9519bd > > > , line 90 and other places > * nx_smpstart.c, > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-8195c6cbcb792a1f2e6b337039a1d111 > >line > 120, removes required spacing after semi-colon > * It seems to screw up the indenttaion after any conditional logic. > Like nx_bringup.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-9aa86408017fde10647798c88d4c62b0 > >, > line 79-110 > * group_malloc.c, > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-6cb24cb106c424372fc4dd44e55b8a07 > >line > 51, screw sup indentation of conditional. also group_zalloc.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-87884d55782f00d26a012863add30407 > >, > line 47 and other places > * group_setupidlefiles.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-aa3bb2f5a7f4db9b96218e96098ea53c > >, > line 118 more destruction of indentation. Also nx_bringup.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-9aa86408017fde10647798c88d4c62b0 > >, > line 74 and other places > * nx_start.c > < > https://github.com/apache/incubator-nuttx/compare/master...starcat-io:explore/clang-format-sched#diff-e36621b38d26a5eeb9f0c9c779931e7b > > > , all braces trashed beginning at line 253. Right alignment of all > comments lost. > > I can't look at any more. Occasionally I see a new error and suspect > that there are more. But these I have describe account for at least > most. I see these kinds of errors in 100's perhaps 1000's of places. > Lots of indentation and alignment errors. It is simply not following > the NuttX coding standard. > > > -- Adam Feuer <a...@starcat.io>
