On Jan 15, 2007, at 8:39 AM, Adrian Crum wrote:
David E. Jones wrote:Actually, the point of this sort of CSS pattern is what you described as the bad side effect, ie having the style tied to the content. If we have anything generic, it should be attached to generic tags, not a messy and confusing and difficult to maintain library of styles like we have now.I just spent the entire weekend slimming down and organizing the maincss.css file. I'm sure it will help eliminate some of the style confusion. I'll post it soon.If we put an id on a div around a product summary block, we don't HAVE to use that in our stock CSS file, but the fact that it is there makes it possible to do something special visually with that section without any change to the FTL file.So, you're saying content-specific styles should stay in the main stylesheet? I apologize if I appear dense, I'm just trying to make sure I understand you correctly before I proceed any further.
Yes, might as well have them all in one file. I think that's much easier to manage, and makes it easy for the browser to cache.
BTW, I plead and beg on my knees Adrian: don't try to make massive changes and submit huge patches! Please! Please! PLEASE! I beg of you! Please try to keep patches more granular and to address a single issue that can be easily reviewed by committers.
This is important for smooth progress in the project. I'm rather concerned right now with the approach various people are trying to take to contribute to OFBiz, and the lack of good review on the part of committers. Following the above plea will help significantly with this, and it will get your patches reviewed and committed far more quickly, and the patches from others committed more quickly and without causing so many negative side-effects for what you are trying to do with OFBiz.
-David
smime.p7s
Description: S/MIME cryptographic signature
