[ 
https://issues.apache.org/jira/browse/OFBIZ-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12479825
 ] 

Jacques Le Roux commented on OFBIZ-804:
---------------------------------------

Mohamed,

A few comments, after a quick review of your patch, please : 
. refer to RBE setting recommendations in 
http://docs.ofbiz.org/display/OFBIZ/Plugins#Plugins-RBE. 
Notably on your patch avoid to use blank lines, spaces around =, the "generated 
by" option. I know these are defaults values but they have been proven to be 
some trouble when updating after 1st release.
. Avoid to have blank labels (as Shark = ). I guess it's just one you missed, 
so it's just FYI : it's better to have no labels, then default labels will be 
used.
. Add the ASL2 header text (see APACHE2_HEADER file in OFBiz root)

You may have a look at an existing file to figure out quickly what about all 
this comments are ;o)

Great work, thanks for your time !

Jacques

> Translation of Ofbiz to arabic
> ------------------------------
>
>                 Key: OFBIZ-804
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-804
>             Project: OFBiz (The Open for Business Project)
>          Issue Type: Task
>          Components: accounting, content, ecommerce, framework, 
> manufacturing, order, party, product, site, workeffort
>         Environment: All
>            Reporter: Mohamed Amine AZZI
>         Assigned To: Jacques Le Roux
>            Priority: Trivial
>         Attachments: CommonUiLabels_ar_DZ.properties
>
>
> Making ana raboc eanbled version of Ofbiz. At the end of this task, Ofbiz 
> users wanting tovuse it in arabic should be able to view every label in 
> arabic, store data in arabic, and have an acceptable RTL UI.
> At the beginning I will start by the translation of the UILabels to arabic, 
> afterwards, I will fournish an RTL Css.
> I noticed that after the work of Adrian Crum, this can be done, but some form 
> screens must be modified, so they bear some style, since some elements which 
> have no style end up aligned to left.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to